Merge pull request cakephp#1375 from markkimsal/features/warn_when_ignoring_up_down

Warn when up or down will be ignored

Author: lorenzo

src/Phinx/Migration/AbstractMigration.php

@@ -326,4 +326,25 @@ public function dropTable($tableName)
         trigger_error('dropTable() is deprecated since 0.10.0. Use $this->table($tableName)->drop()->save() instead.', E_USER_DEPRECATED);
         $this->table($tableName)->drop()->save();
     }
+
+    /**
+     * Perform checks on the migration, print a warning
+     * if there are potential problems.
+     *
+     * Right now, the only check is if there is both a `change()` and
+     * an `up()` or a `down()` method.
+     *
+     * @return void
+     */
+    public function preFlightCheck()
+    {
+        if (method_exists($this, MigrationInterface::CHANGE)) {
+            if (method_exists($this, MigrationInterface::UP) ||
+                method_exists($this, MigrationInterface::DOWN) ) {
+                $this->output->writeln(sprintf(
+                    '<comment>warning</comment> Migration contains both change() and/or up()/down() methods.  <options=bold>Ignoring up() and down()</>.'
+                ));
+            }
+        }
+    }
 }

src/Phinx/Migration/Manager.php

@@ -380,6 +380,7 @@ public function executeMigration($name, MigrationInterface $migration, $directio
             ' <info>' . $migration->getVersion() . ' ' . $migration->getName() . ':</info>' .
             ' <comment>' . ($direction === MigrationInterface::UP ? 'migrating' : 'reverting') . '</comment>'
         );
+        $migration->preFlightCheck();
 
         // Execute the migration and log the time elapsed.
         $start = microtime(true);

src/Phinx/Migration/MigrationInterface.php

@@ -248,4 +248,12 @@ public function hasTable($tableName);
      * @return \Phinx\Db\Table
      */
     public function table($tableName, $options);
+
+    /**
+     * Perform checks on the migration, print a warning
+     * if there are potential problems.
+     *
+     * @return void
+     */
+    public function preFlightCheck();
 }