Skip to content

Fix incorrect machineinformer callback #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aaronfern merged 1 commit into from
Dec 9, 2025
Merged

Fix incorrect machineinformer callback #1002

aaronfern merged 1 commit into from
Dec 9, 2025

Conversation

@aaronfern
Copy link
Member

@aaronfern aaronfern commented Jun 6, 2025

What this PR does / why we need it:
This PR fixes an incorrect machineinformer callback

Which issue(s) this PR fixes:
Fixes #988

Special notes for your reviewer:

Release note:

@aaronfern aaronfern requested a review from a team as a code owner June 6, 2025 05:44
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jun 6, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 6, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 6, 2025
rishabh-11
rishabh-11 reviewed Jun 30, 2025
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

How was this not caught in the unit tests?

@gardener-robot
Copy link

gardener-robot commented Jun 30, 2025

@rishabh-11 Command /lgtm is not available to you but only to a Maintainer, Member.

@aaronfern
Copy link
Member Author

aaronfern commented Jul 2, 2025

How was this not caught in the unit tests?

Need to revisit the unit tests after this 🥴

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 28, 2025
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Dec 9, 2025
@gardener-robot
Copy link

gardener-robot commented Dec 9, 2025

@aaronfern You need rebase this pull request with latest master branch. Please check.

@aaronfern aaronfern merged commit 8f7eb07 into gardener:master Dec 9, 2025
12 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gagan16k gagan16k gagan16k approved these changes

@r4mek r4mek r4mek approved these changes

+1 more reviewer

@rishabh-11 rishabh-11 rishabh-11 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@gagan16k gagan16k

@r4mek r4mek

Labels

needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix incorrect MachineInformer callback

7 participants

@aaronfern @gardener-robot @gagan16k @r4mek @rishabh-11 @gardener-robot-ci-2 @gardener-robot-ci-3