fix compile for SocketIoReadableNativeMap #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corrects the following error: constructor ReadableNativeMap in class ReadableNativeMap cannot be applied to given types closes #8
|
Review this please |
|
@gcrabtree, is this project still maintained? |
|
@gcrabtree, I take it this is not maintained anymore. Care to give this up to someone else so they can maintain it? |
|
👍 |
Anybody willing to take this project on? I don't dabble enough in mobile to justify it. |
|
I know this is a bit old now but there are a few forks with work done, such as
Perhaps would it be better to recreate PRs over there ? |
|
closing this so it's not on my dashboard anymore. i take it it won't get merged. might not be relevant anymore as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8
corrects the following error:
making this change manually in my local
node_modules/react-native-socketiodirectory corrected the issue.