Skip to content

Commit 5e61785

Browse files
authored
Core: five tests now fail when the rule they guard breaks (#1950)
1 parent 3f5f2be commit 5e61785

7 files changed

Lines changed: 40 additions & 17 deletions

File tree

‎core/crates/gem_evm/src/rpc/alchemy.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,6 @@ mod tests {
5353

5454
let transaction_ids = client.get_transactions_by_address("0x123", 2).await.unwrap();
5555

56-
assert_eq!(transaction_ids, vec![TransactionReference::new("0xin".to_string(), Some(3)), TransactionReference::new("0xout".to_string(), Some(2))]);
56+
assert_eq!(transaction_ids, vec![TransactionReference::new("0xduplicate".to_string(), Some(3)), TransactionReference::new("0xout".to_string(), Some(2))]);
5757
}
5858
}

‎core/crates/gem_evm/src/rpc/indexer/mod.rs‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,10 @@ mod tests {
265265

266266
assert_eq!(
267267
transactions.transaction_requests().unwrap(),
268-
vec![TransactionIdRequest::new(Chain::ZkSync, "0xin".to_string(), Some(3)), TransactionIdRequest::new(Chain::ZkSync, "0xout".to_string(), Some(2)),]
268+
vec![
269+
TransactionIdRequest::new(Chain::ZkSync, "0xduplicate".to_string(), Some(3)),
270+
TransactionIdRequest::new(Chain::ZkSync, "0xout".to_string(), Some(2)),
271+
]
269272
);
270273
assert_eq!(
271274
balances,

‎core/crates/gem_evm/src/rpc/mapper.rs‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -562,17 +562,23 @@ mod tests {
562562
};
563563

564564
let receipt = TransactionReceipt {
565-
gas_used: BigUint::from(22496u32),
565+
gas_used: BigUint::from(21880u32),
566566
effective_gas_price: BigUint::from(5_000_000_000u64),
567567
..TransactionReceipt::mock()
568568
};
569+
let contract_call_receipt = TransactionReceipt {
570+
gas_used: BigUint::from(22497u32),
571+
..receipt.clone()
572+
};
569573

570574
let mapped = EthereumMapper::map_transaction(Chain::SmartChain, &transaction, &receipt, &BigUint::from(1735671600u64)).unwrap();
575+
let contract_call = EthereumMapper::map_transaction(Chain::SmartChain, &transaction, &contract_call_receipt, &BigUint::from(1735671600u64)).unwrap();
571576

572577
assert_eq!(mapped.transaction_type, TransactionType::Transfer);
573578
assert_eq!(mapped.asset_id, AssetId::from_chain(Chain::SmartChain));
574579
assert_eq!(mapped.memo, Some(memo.to_string()));
575580
assert_eq!(mapped.data, Some(input));
581+
assert_eq!(contract_call.transaction_type, TransactionType::SmartContractCall);
576582
}
577583

578584
#[test]
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
{
22
"transfers": [
33
{
4-
"blockNum": "0x2",
5-
"hash": "0xout"
4+
"blockNum": "0x3",
5+
"hash": "0xduplicate"
66
},
77
{
8-
"blockNum": "0x1",
9-
"hash": "0xduplicate"
8+
"blockNum": "0x2",
9+
"hash": "0xout"
1010
}
1111
]
1212
}

‎core/crates/gem_evm/testdata/alchemy_get_asset_transfers_to.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
"transfers": [
33
{
44
"blockNum": "0x3",
5-
"hash": "0xin"
5+
"hash": "0xduplicate"
66
},
77
{
88
"blockNum": "0x1",
9-
"hash": "0xduplicate"
9+
"hash": "0xin"
1010
}
1111
]
1212
}

‎core/crates/gem_hypercore/src/provider/perpetual_mapper.rs‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -879,6 +879,14 @@ mod tests {
879879
assert_eq!(summary.account_leverage, 0.5);
880880
assert_eq!(summary.margin_usage, 0.2);
881881
assert_eq!(summary.unrealized_pnl, 0.0);
882+
883+
let isolated: AssetPositions = serde_json::from_str(include_str!("../../testdata/perpetual_positions_response_clearinghouse_state_isolated.json")).unwrap();
884+
let with_positions = [AssetPositions::mock(), isolated];
885+
let balance = with_positions.iter().map(map_perpetual_balance).sum();
886+
887+
let summary = map_account_summary(&with_positions, &balance);
888+
889+
assert_eq!(summary.unrealized_pnl, -0.05586, "the PnL of every open position on every dex adds up");
882890
}
883891

884892
#[test]

‎core/gemstone/src/services/simulation.rs‎

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,6 @@ pub fn asset_status_rows(changes: &[SimulationBalanceChange], assets: &[AssetBas
439439
mod tests {
440440
use super::*;
441441
use crate::duration_formatter::GemDurationUnit;
442-
use crate::models::list::suspicious_address_notice;
443442
use crate::services::assets::rules::default_asset_basic;
444443
use crate::services::node::GemNodeService;
445444
use crate::testkit::{TestAlienProvider, mock_wc_ethereum_transaction};
@@ -457,7 +456,7 @@ mod tests {
457456
SimulationWarning::mock(SimulationWarningType::PermitBatchApproval(None)),
458457
SimulationWarning::mock(SimulationWarningType::NftCollectionApproval(AssetId::from_chain(Chain::Ethereum))),
459458
SimulationWarning::mock(SimulationWarningType::ExternallyOwnedSpender),
460-
SimulationWarning::mock(SimulationWarningType::SuspiciousSpender),
459+
SimulationWarning::new(SimulationSeverity::Critical, SimulationWarningType::SuspiciousSpender, None),
461460
SimulationWarning::validation_error("Chain ID mismatch"),
462461
]);
463462
let notice = |title: GemListRowTitle, message: Option<GemLocalizedText>| GemListRow::Notice {
@@ -475,7 +474,11 @@ mod tests {
475474
unlimited,
476475
notice(GemListRowTitle::NftCollectionApproval, None),
477476
notice(GemListRowTitle::Warning, Some(GemLocalizedText::ExternallyOwnedSpenderWarning)),
478-
suspicious_address_notice(GemNoticeKind::Warning),
477+
GemListRow::Notice {
478+
title: GemListRowTitle::SuspiciousAddress,
479+
message: Some(GemLocalizedText::SuspiciousAddressDescription),
480+
kind: GemNoticeKind::Error,
481+
},
479482
GemListRow::Notice {
480483
title: GemListRowTitle::Error,
481484
message: Some(GemLocalizedText::Text { text: "Chain ID mismatch".to_string() }),
@@ -745,22 +748,25 @@ mod tests {
745748
#[test]
746749
fn test_wallet_connect_send_transaction_ignores_simulation_error() {
747750
futures::executor::block_on(async {
748-
let provider = Arc::new(TestAlienProvider::with_status(200));
751+
let provider = Arc::new(TestAlienProvider::offline());
749752
let service = GemSimulationService::new(provider.clone(), Arc::new(GemNodeService::mock()));
753+
let fixture: serde_json::Value = serde_json::from_str(include_str!("../../../crates/gem_wallet_connect/testdata/solana_sign_all_transactions.json")).unwrap();
754+
let data = serde_json::json!({ "transaction": fixture["transactions"][0] });
750755

751756
let result = service
752757
.simulate_send_transaction(
753758
Chain::Solana,
754759
WalletConnectTransactionType::Solana {
755760
output_type: primitives::TransferDataOutputType::EncodedTransaction,
756761
},
757-
"invalid simulation input".to_string(),
762+
data.to_string(),
758763
"",
759764
)
760-
.await;
765+
.await
766+
.unwrap();
761767

762-
assert!(result.is_ok());
763-
assert!(provider.requested_paths().is_empty());
768+
assert_eq!(result, SimulationResult::default());
769+
assert!(!provider.requested_paths().is_empty());
764770
});
765771
}
766772

0 commit comments

Comments
 (0)