Reduce reliance on C++ exceptions in the base framework #5245

nfeske · 2024-06-11T10:00:23Z

Down the road, I'd like to clear the base framework from the use of C++ exceptions, using the attempt pattern for error handling instead (see https://genode.org/documentation/genode-foundations/24.05/api/Fundamental_types.html#Exception-less_error_handling). Let's move gradually to this direction.

This exception got introduced as a mere convenience for implementers of 'Child_policy' but required a special case in the base library. Following the goal of eliminating exceptions from the base system, this patch removes it by making a server_id_space mandatory. Issue #5245

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue genodelabs#5245

- Use attempt pattern for error handling - Replace lookup of pointers by with_ pattern - Remove virtual Trace::Session methods - Merge client.h into connection.h Issue genodelabs#5245

- Use attempt pattern for error handling - Replace lookup of pointers by with_ pattern - Remove virtual Trace::Session methods - Merge client.h into connection.h - Update coding style of test/trace Issue genodelabs#5245

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue #5245

- Use attempt pattern for error handling - Replace lookup of pointers by with_ pattern - Remove virtual Trace::Session methods - Merge client.h into connection.h - Update coding style of test/trace Issue #5245

Issue #5245

nfeske · 2024-06-12T14:56:06Z

Commit a82a3e6 and fixup 6af5a3e remove C++ exceptions from core's TRACE session interface and adjust the components throughout Genode's source tree. The new version of the interface is tighter in several respects. Hence, this change requires the adaptation of trace clients (@alex-ab thinking of top_view).

The split between client.h and connection.h has been removed. Note that error types between the RPC functions and the corresponding Connection methods differ because the Connection handles the OUT_OF_CAPS and OUT_OF_RAM conditions.
Basic types have been replaced by structs
The notion of invalid policy IDs does not exist anymore. If a policy ID cannot be created, the alloc_policy operation reflects this condition explicitly via an Alloc_policy_error. At the clients, the former instances of Policy_id (which could be invalid) are now mapped to Trace::Connection::Alloc_policy_result now.

@jschlatow I have adapted the trace recorder to this change but admittedly haven't tested it. I'd appreciate you giving it a spin.

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue #5245 Fixes #5246

- Use attempt pattern for error handling - Replace lookup of pointers by with_ pattern - Remove virtual Trace::Session methods - Merge client.h into connection.h - Update coding style of test/trace Issue #5245

Issue #5245

While changing 'Pd_session::alloc_context', this patch also tightens the type of the imprint argument. Issue #5245

Remove exceptions, replace pointer lookup by with_ pattern, use Xml_node::attribute_value, constness, naming of signal handlers Issue #5245

This patch replaces exceptions of the PD session RPC interface with result types. The change of the quota-transfer RPC functions required the adaptation of base/quota_transfer.h and base/child.h. The 'alloc_signal_source' method has been renamed to 'signal_source' to avoid an exceedingly long name of the corresponding result type. The Pd_session::map function takes a 'Virt_range' instead of basic-type arguments. The 'Signal_source_capability' alias for 'Capability<Signal_source>' has been removed. Issue #5245

nfeske · 2024-06-14T13:41:46Z

Commit 7cac494 takes another step by revisiting the PD session interface.

jschlatow · 2024-06-14T18:29:39Z

@jschlatow I have adapted the trace recorder to this change but admittedly haven't tested it. I'd appreciate you giving it a spin.

It's spinning happily.

Issue #5245

This patch removes the exception formerly thrown by 'Cpu_thread::state' and turns the 'Thread_state' structure into a plain compound type w/o a constructor. Issue #5245 Fixes #5250

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue genodelabs#5245 Fixes genodelabs#5246

- Use attempt pattern for error handling - Replace lookup of pointers by with_ pattern - Remove virtual Trace::Session methods - Merge client.h into connection.h - Update coding style of test/trace Issue genodelabs#5245

Issue genodelabs#5245

While changing 'Pd_session::alloc_context', this patch also tightens the type of the imprint argument. Issue genodelabs#5245

Remove exceptions, replace pointer lookup by with_ pattern, use Xml_node::attribute_value, constness, naming of signal handlers Issue genodelabs#5245

This patch replaces exceptions of the PD session RPC interface with result types. The change of the quota-transfer RPC functions required the adaptation of base/quota_transfer.h and base/child.h. The 'alloc_signal_source' method has been renamed to 'signal_source' to avoid an exceedingly long name of the corresponding result type. The Pd_session::map function takes a 'Virt_range' instead of basic-type arguments. The 'Signal_source_capability' alias for 'Capability<Signal_source>' has been removed. Issue genodelabs#5245

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue #5245 Fixes #5246

- Use attempt pattern for error handling - Replace lookup of pointers by with_ pattern - Remove virtual Trace::Session methods - Merge client.h into connection.h - Update coding style of test/trace Issue #5245

Issue genodelabs/genode#5245

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue genodelabs#5245 Fixes genodelabs#5246

- Use attempt pattern for error handling - Replace lookup of pointers by with_ pattern - Remove virtual Trace::Session methods - Merge client.h into connection.h - Update coding style of test/trace Issue genodelabs#5245

Issue genodelabs#5245

While changing 'Pd_session::alloc_context', this patch also tightens the type of the imprint argument. Issue genodelabs#5245

Remove exceptions, replace pointer lookup by with_ pattern, use Xml_node::attribute_value, constness, naming of signal handlers Issue genodelabs#5245

This patch replaces exceptions of the PD session RPC interface with result types. The change of the quota-transfer RPC functions required the adaptation of base/quota_transfer.h and base/child.h. The 'alloc_signal_source' method has been renamed to 'signal_source' to avoid an exceedingly long name of the corresponding result type. The Pd_session::map function takes a 'Virt_range' instead of basic-type arguments. The 'Signal_source_capability' alias for 'Capability<Signal_source>' has been removed. Issue genodelabs#5245

Issue genodelabs/genode#5245

nfeske · 2024-06-25T11:18:19Z

@cproc may you take care of adjusting qt5 to the latest Region_map change?

Issue genodelabs/genode#5245

genodelabs/genode#5245

Issue genodelabs#5245

cproc · 2024-06-25T15:49:41Z

Commit f89482c adapts qt5.

Issue #5245

nfeske · 2024-06-25T16:43:24Z

Fantastic! Thank you @cproc.

Issue #5245

This patch replaces the former Child::Process and Child::Process::Loaded_executable classes by static functions that return failure conditions as return values. Issue #5245

nfeske · 2024-07-01T15:38:37Z

Commit 3c00a1b removes exceptions from the parent interface.
Commit 87952dc revisits the child creation (ELF loading, process starting) in this respect.

The 'Thread_creation_failed' error is now reflected as 'Thread::Start_result' return value. This change also removes the use of 'Invalid_thread' within core as this exception is an alias of Cpu_session::Thread_creation_failed. Issue #5245

- Remove exceptions - Use 'Attr' struct for attach arguments - Let 'attach' return 'Range' instead of 'Local_addr' - Renamed 'Region_map::State' to 'Region_map::Fault' Issue #5245 Fixes #5070

Issue #5245

This patch replaces the former Child::Process and Child::Process::Loaded_executable classes by static functions that return failure conditions as return values. Issue #5245

To maintain ease of use at the client side, the OUT_OF_RAM and OUT_OF_CAPS results are handled at the 'Gui::Connection' now. Gui::Connection does not inherit the Gui::Session interface any longer, which allows for the use of different result types. Issue genodelabs#5242 Issue genodelabs#5245

To maintain ease of use at the client side, the OUT_OF_RAM and OUT_OF_CAPS results are handled at the 'Gui::Connection' now. Gui::Connection does not inherit the Gui::Session interface any longer, which allows for the use of different result types. Issue #5242 Issue #5245

This patch removes the only residual C++ exception from the kernel part of core, eliminating the risk of the kernel thread trying to enter the kernel itself via the C++ exception-handling path. When throwing an exception, __cxa_allocate_exception invokes the cxx_heap, which synchronizes accesses via a Genode::Mutex. In the contention case, the blocking of the mutex issues a syscall to pause the caller. The patch fixes the problem by replacing the exception with a return value. Fixes #5382 Issue #5245

nfeske added a commit to nfeske/genode that referenced this issue Jun 11, 2024

Remove Xml_node::attribute accessors

74db101

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue genodelabs#5245

nfeske added a commit to nfeske/genode that referenced this issue Jun 11, 2024

Remove Xml_node::attribute accessors

c36959d

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue genodelabs#5245

nfeske added a commit to nfeske/genode that referenced this issue Jun 11, 2024

Remove Xml_node::attribute accessors

ec3e456

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue genodelabs#5245

nfeske mentioned this issue Jun 12, 2024

Remove Xml_node::attribute accessor(s) #5246

Closed

nfeske added a commit that referenced this issue Jun 12, 2024

Remove Xml_node::attribute accessors

f1c4a88

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue #5245

nfeske added a commit that referenced this issue Jun 12, 2024

fixup "Remove exceptions from TRACE session interface" (lib/vfs_trace)

6af5a3e

Issue #5245

nfeske added a commit that referenced this issue Jun 12, 2024

Remove Xml_node::attribute accessors

fa4b191

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue #5245 Fixes #5246

nfeske added a commit that referenced this issue Jun 12, 2024

fixup "Remove exceptions from TRACE session interface" (lib/vfs_trace)

1bd2cf2

Issue #5245

nfeske added a commit that referenced this issue Jun 12, 2024

Remove Pd_session::Invalid_signal_source exception

90b21ce

While changing 'Pd_session::alloc_context', this patch also tightens the type of the imprint argument. Issue #5245

nfeske added a commit that referenced this issue Jun 13, 2024

app/acpi_event: update coding style

060c675

Remove exceptions, replace pointer lookup by with_ pattern, use Xml_node::attribute_value, constness, naming of signal handlers Issue #5245

nfeske added a commit that referenced this issue Jun 17, 2024

Remove exceptions from Rm_session interface

a3ab6df

Issue #5245

nfeske mentioned this issue Jun 17, 2024

Remove Service_denied exception from API #5251

Open

m-stein pushed a commit to m-stein/genode that referenced this issue Jun 18, 2024

Remove Xml_node::attribute accessors

16843c4

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue genodelabs#5245 Fixes genodelabs#5246

m-stein pushed a commit to m-stein/genode that referenced this issue Jun 18, 2024

fixup "Remove exceptions from TRACE session interface" (lib/vfs_trace)

1ca2b95

Issue genodelabs#5245

m-stein pushed a commit to m-stein/genode that referenced this issue Jun 18, 2024

Remove Pd_session::Invalid_signal_source exception

2d35c28

While changing 'Pd_session::alloc_context', this patch also tightens the type of the imprint argument. Issue genodelabs#5245

m-stein pushed a commit to m-stein/genode that referenced this issue Jun 18, 2024

app/acpi_event: update coding style

871cb6e

Remove exceptions, replace pointer lookup by with_ pattern, use Xml_node::attribute_value, constness, naming of signal handlers Issue genodelabs#5245

chelmuth pushed a commit that referenced this issue Jun 18, 2024

Remove Xml_node::attribute accessors

722234b

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue #5245 Fixes #5246

nfeske added a commit to genodelabs/genode-world that referenced this issue Jun 24, 2024

jdk: adaptation to Genode::Region_map changes

ae29d5c

Issue genodelabs/genode#5245

m-stein pushed a commit to m-stein/genode that referenced this issue Jun 25, 2024

Remove Xml_node::attribute accessors

05885d5

This patch removes the two 'Xml_node::attribute' accessors along with the 'Nonexistent_attribute' exception. Issue genodelabs#5245 Fixes genodelabs#5246

m-stein pushed a commit to m-stein/genode that referenced this issue Jun 25, 2024

fixup "Remove exceptions from TRACE session interface" (lib/vfs_trace)

0b6f2c4

Issue genodelabs#5245

m-stein pushed a commit to m-stein/genode that referenced this issue Jun 25, 2024

Remove Pd_session::Invalid_signal_source exception

63b1b27

While changing 'Pd_session::alloc_context', this patch also tightens the type of the imprint argument. Issue genodelabs#5245

m-stein pushed a commit to m-stein/genode that referenced this issue Jun 25, 2024

app/acpi_event: update coding style

1ca9d95

Remove exceptions, replace pointer lookup by with_ pattern, use Xml_node::attribute_value, constness, naming of signal handlers Issue genodelabs#5245

nfeske pushed a commit to genodelabs/genode-world that referenced this issue Jun 25, 2024

seoul: adapt to attach changes

33a721b

Issue genodelabs/genode#5245

nfeske added a commit to genodelabs/genode-world that referenced this issue Jun 25, 2024

raw_audio_sink: adapt to Genode::Region_map change

1b4f3a1

Issue genodelabs/genode#5245

cproc added a commit to cproc/qt5-dev that referenced this issue Jun 25, 2024

Adaptation to 'Genode::Region_map' changes

c92bd9e

genodelabs/genode#5245

cproc added a commit to cproc/genode that referenced this issue Jun 25, 2024

qt5: adaptation to 'Genode::Region_map' changes

f89482c

Issue genodelabs#5245

nfeske pushed a commit that referenced this issue Jun 25, 2024

qt5: adaptation to 'Genode::Region_map' changes

0bf5a6f

Issue #5245

nfeske added a commit that referenced this issue Jul 1, 2024

Remove exceptions from 'Parent' interface

3c00a1b

Issue #5245

nfeske added a commit that referenced this issue Jul 1, 2024

base/child.h: remove exceptions from process init

87952dc

This patch replaces the former Child::Process and Child::Process::Loaded_executable classes by static functions that return failure conditions as return values. Issue #5245

nfeske added a commit that referenced this issue Jul 2, 2024

Rework Region_map interface

0105494

- Remove exceptions - Use 'Attr' struct for attach arguments - Let 'attach' return 'Range' instead of 'Local_addr' - Renamed 'Region_map::State' to 'Region_map::Fault' Issue #5245 Fixes #5070

nfeske pushed a commit that referenced this issue Jul 2, 2024

qt5: adaptation to 'Genode::Region_map' changes

37e0d20

Issue #5245

nfeske added a commit that referenced this issue Jul 2, 2024

Remove exceptions from 'Parent' interface

0288cff

Issue #5245

nfeske added a commit that referenced this issue Jul 2, 2024

base/child.h: remove exceptions from process init

943dfa1

This patch replaces the former Child::Process and Child::Process::Loaded_executable classes by static functions that return failure conditions as return values. Issue #5245

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce reliance on C++ exceptions in the base framework #5245

Reduce reliance on C++ exceptions in the base framework #5245

nfeske commented Jun 11, 2024

nfeske commented Jun 12, 2024

nfeske commented Jun 14, 2024

jschlatow commented Jun 14, 2024

nfeske commented Jun 25, 2024

cproc commented Jun 25, 2024

nfeske commented Jun 25, 2024

nfeske commented Jul 1, 2024

Reduce reliance on C++ exceptions in the base framework #5245

Reduce reliance on C++ exceptions in the base framework #5245

Comments

nfeske commented Jun 11, 2024

nfeske commented Jun 12, 2024

nfeske commented Jun 14, 2024

jschlatow commented Jun 14, 2024

nfeske commented Jun 25, 2024

cproc commented Jun 25, 2024

nfeske commented Jun 25, 2024

nfeske commented Jul 1, 2024