Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with importers/exporters and container inheritance #62

Open
m-weigand opened this issue Jun 17, 2019 · 1 comment
Open

Issues with importers/exporters and container inheritance #62

m-weigand opened this issue Jun 17, 2019 · 1 comment
Assignees
@m-weigand
Labels
bug enhancement

Comments

@m-weigand
Copy link
Contributor

At this point the TDIP container inherits the ERT container, and the CR container inherits the TDIP container. Thus, the CR container still has all importer/exporter functions from ERT and TDIP. This usually does not makes sense, and I think we need to restructure the code.
@m-weigand m-weigand self-assigned this Jun 17, 2019
@florian-wagner
Copy link
Collaborator

Maybe a plain BaseContainer which is inherited by all the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-weigand m-weigand

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@florian-wagner @m-weigand