fix: make all partial args result in optional arg

Author: Yash-Singh1

packages/convex-helpers/react/sessions.test.ts

@@ -26,6 +26,17 @@ expectTypeOf<
   >
 >().toEqualTypeOf<[{ arg: string } | "skip"]>();
 
+expectTypeOf<
+  SessionQueryArgsArray<
+    FunctionReference<
+      "query",
+      "public",
+      { arg?: string; sessionId: SessionId | null },
+      any
+    >
+  >
+>().toEqualTypeOf<[args?: { arg?: string } | "skip"]>();
+
 expectTypeOf<
   SessionQueryArgsArray<
     FunctionReference<"query", "public", { sessionId: SessionId | null }, any>
@@ -43,6 +54,17 @@ expectTypeOf<
   >
 >().toEqualTypeOf<[{ arg: string }]>();
 
+expectTypeOf<
+  SessionArgsArray<
+    FunctionReference<
+      "mutation",
+      "public",
+      { arg?: string; sessionId: SessionId },
+      any
+    >
+  >
+>().toEqualTypeOf<[args?: { arg?: string }]>();
+
 expectTypeOf<
   SessionArgsArray<
     FunctionReference<"mutation", "public", { sessionId: SessionId }, any>

packages/convex-helpers/react/sessions.ts

@@ -73,23 +73,33 @@ type SessionFunction<
   Args = any,
 > = FunctionReference<T, "public", { sessionId: SessionId } & Args>;
 
+type ArgsWithoutSession<
+  Fn extends SessionFunction<"query" | "mutation" | "action">,
+> = BetterOmit<FunctionArgs<Fn>, "sessionId">;
+
 export type SessionQueryArgsArray<Fn extends SessionFunction<"query">> =
   keyof FunctionArgs<Fn> extends "sessionId"
     ? [args?: EmptyObject | "skip"]
-    : [args: BetterOmit<FunctionArgs<Fn>, "sessionId"> | "skip"];
+    : Partial<ArgsWithoutSession<Fn>> extends ArgsWithoutSession<Fn>
+      ? [args?: ArgsWithoutSession<Fn> | "skip"]
+      : [args: ArgsWithoutSession<Fn> | "skip"];
 
 export type SessionArgsArray<
   Fn extends SessionFunction<"query" | "mutation" | "action">,
 > = keyof FunctionArgs<Fn> extends "sessionId"
   ? [args?: EmptyObject]
-  : [args: BetterOmit<FunctionArgs<Fn>, "sessionId">];
+  : Partial<ArgsWithoutSession<Fn>> extends ArgsWithoutSession<Fn>
+    ? [args?: ArgsWithoutSession<Fn>]
+    : [args: ArgsWithoutSession<Fn>];
 
 export type SessionArgsAndOptions<
   Fn extends SessionFunction<"mutation">,
   Options,
 > = keyof FunctionArgs<Fn> extends "sessionId"
   ? [args?: EmptyObject, options?: Options]
-  : [args: BetterOmit<FunctionArgs<Fn>, "sessionId">, options?: Options];
+  : Partial<ArgsWithoutSession<Fn>> extends ArgsWithoutSession<Fn>
+    ? [args: ArgsWithoutSession<Fn>, options?: Options]
+    : [args: ArgsWithoutSession<Fn>, options?: Options];
 
 type SessionPaginatedQueryFunction<
   Args extends { paginationOpts: PaginationOptions } = {