Skip to content

Commit 9b2fb2b

Browse files
authored
fix: unable to save env in git synced project (#1471)
1 parent dc10a3c commit 9b2fb2b

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

frontend/src/lib/services/project-service.ts

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,18 @@ export class ProjectService extends BaseAPIService {
8888
return res.data.data;
8989
}
9090

91-
async updateProject(projectId: string, name: string, composeContent: string, envContent?: string): Promise<Project> {
91+
async updateProject(projectId: string, name?: string, composeContent?: string, envContent?: string): Promise<Project> {
9292
const envId = await environmentStore.getCurrentEnvironmentId();
93-
const payload = {
94-
name,
95-
composeContent,
96-
envContent
97-
};
93+
const payload: Record<string, string> = {};
94+
if (name !== undefined) {
95+
payload.name = name;
96+
}
97+
if (composeContent !== undefined) {
98+
payload.composeContent = composeContent;
99+
}
100+
if (envContent !== undefined) {
101+
payload.envContent = envContent;
102+
}
98103
return this.handleResponse(this.api.put(`/environments/${envId}/projects/${projectId}`, payload));
99104
}
100105

frontend/src/routes/(app)/projects/[projectId]/+page.svelte

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,14 +175,17 @@
175175
async function handleSaveChanges() {
176176
if (!project || !hasChanges) return;
177177
178-
const validated = form.validate();
178+
const formValues = form.data();
179+
const validated = isGitOpsManaged ? formValues : form.validate();
179180
if (!validated) return;
180181
181182
const { name, composeContent, envContent } = validated;
183+
const namePayload = isGitOpsManaged ? undefined : name;
184+
const composePayload = isGitOpsManaged ? undefined : composeContent;
182185
183186
// First update the main project files
184187
handleApiResultWithCallbacks({
185-
result: await tryCatch(projectService.updateProject(projectId, name, composeContent, envContent)),
188+
result: await tryCatch(projectService.updateProject(projectId, namePayload, composePayload, envContent)),
186189
message: m.common_save_failed(),
187190
setLoadingState: (value) => (isLoading.saving = value),
188191
onSuccess: async (updatedStack: Project) => {

0 commit comments

Comments
 (0)