cleanup tests

fix templated spawn fns

fixup lints

try to suppress test warnings from criterion

test string_views

expand use of type_traits in tests

Author: CamJN

test/.clang-tidy

@@ -1,2 +1,2 @@
-Checks: '*,-altera-*,-fuchsia-*,-llvmlibc-*-namespace,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-llvmlibc-restrict-system-libc-headers,-portability-restrict-system-includes,-cppcoreguidelines-pro-type-cstyle-cast,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-avoid-magic-numbers,-hicpp-vararg,-readability-magic-numbers,-concurrency-mt-unsafe,-hicpp-no-array-decay,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-avoid-do-while,-cppcoreguidelines-avoid-non-const-global-variables,-misc-use-anonymous-namespace,-misc-const-correctness,-readability-identifier-length,-cppcoreguidelines-pro-type-member-init,-readability-function-cognitive-complexity,-cert-err58-cpp,-hicpp-member-init-readability-simplify-boolean-expr,-modernize-use-trailing-return-type'
+Checks: '*,-altera-*,-boost-use-*,-fuchsia-*,-llvmlibc-*,-cert-err58-cpp,-cppcoreguidelines-avoid-do-while,-cppcoreguidelines-avoid-non-const-global-variables,-cppcoreguidelines-no-malloc,-cppcoreguidelines-owning-memory,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-type-cstyle-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-vararg,-google-build-using-namespace,-hicpp-member-init,-hicpp-no-malloc,-hicpp-vararg,-misc-use-anonymous-namespace,-misc-use-internal-linkage,-modernize-type-traits,-modernize-use-ranges,-modernize-use-trailing-return-type,-readability-function-cognitive-complexity,-readability-identifier-length,-readability-isolate-declaration'
 HeaderFilterRegex: 'lib_unit_tests.hpp'

test/Makefile

@@ -36,7 +36,7 @@ lib_unit_tests: $(BIN_DIR)/lib_unit_tests
 
 #unit test library
 $(BIN_DIR)/lib_unit_tests: CPPFLAGS := -MMD -MP -fvisibility=hidden
-$(BIN_DIR)/lib_unit_tests: CXXFLAGS += -fblocks $(shell pkg-config --cflags getargv criterion) -O0 -g3 -fcoverage-mapping $(SANI_FLAGS)
+$(BIN_DIR)/lib_unit_tests: CXXFLAGS += -fblocks $(shell pkg-config --cflags getargv) $(shell pkg-config --cflags criterion | sed 's/-I/-isystem /g') -O0 -g3 -fcoverage-mapping $(SANI_FLAGS) -Wno-unused-value
 $(BIN_DIR)/lib_unit_tests: EXE      := $(BIN_DIR)/lib_unit_tests
 $(BIN_DIR)/lib_unit_tests: LDLIBS   :=  $(SANI_FLAGS)
 $(BIN_DIR)/lib_unit_tests: LDFLAGS  := $(shell pkg-config --libs getargv criterion)