http202 remove reflection from unit tests

Signed-off-by: davidradl <[email protected]>

Author: davidradl

src/main/java/com/getindata/connectors/http/internal/table/lookup/JavaNetHttpPollingClient.java

@@ -269,7 +269,8 @@ private Collection<RowData> deserialize(String responseBody) throws IOException
         }
     }
 
-    private List<RowData> deserializeSingleValue(byte[] rawBytes) throws IOException {
+    @VisibleForTesting
+    List<RowData> deserializeSingleValue(byte[] rawBytes) throws IOException {
         List<RowData> result = new ArrayList<>();
         responseBodyDecoder.deserialize(rawBytes, createRowDataCollector(result));
         return result;
@@ -302,7 +303,8 @@ public void close() {
         }
     }
 
-    private List<RowData> deserializeArray(byte[] rawBytes) throws IOException {
+    @VisibleForTesting
+    List<RowData> deserializeArray(byte[] rawBytes) throws IOException {
         List<JsonNode> rawObjects =
             objectMapper.readValue(rawBytes, new TypeReference<>() {
             });

src/test/java/com/getindata/connectors/http/internal/table/lookup/JavaNetHttpPollingClientTest.java

@@ -357,12 +357,8 @@ public org.apache.flink.api.common.typeinfo.TypeInformation<RowData> getProduced
         );
 
         // WHEN
-        java.lang.reflect.Method method = JavaNetHttpPollingClient.class
-            .getDeclaredMethod("deserializeArray", byte[].class);
-        method.setAccessible(true);
-
         String jsonArray = "[{\"key\":\"value1\"},{\"key\":\"value2\"}]";
-        List<RowData> result = (List<RowData>) method.invoke(client, jsonArray.getBytes());
+        List<RowData> result = client.deserializeArray(jsonArray.getBytes());
 
         // THEN
         assertThat(result).isNotNull();
@@ -415,12 +411,8 @@ public org.apache.flink.api.common.typeinfo.TypeInformation<RowData> getProduced
         );
 
         // WHEN
-        java.lang.reflect.Method method = JavaNetHttpPollingClient.class
-            .getDeclaredMethod("deserializeArray", byte[].class);
-        method.setAccessible(true);
-
         String jsonArray = "[{\"key\":\"value1\"},null,{\"key\":\"value2\"}]";
-        List<RowData> result = (List<RowData>) method.invoke(client, jsonArray.getBytes());
+        List<RowData> result = client.deserializeArray(jsonArray.getBytes());
 
         // THEN - null nodes should be skipped
         assertThat(result).isNotNull();
@@ -478,12 +470,8 @@ public org.apache.flink.api.common.typeinfo.TypeInformation<RowData> getProduced
         );
 
         // WHEN
-        java.lang.reflect.Method method = JavaNetHttpPollingClient.class
-            .getDeclaredMethod("deserializeArray", byte[].class);
-        method.setAccessible(true);
-
         String jsonArray = "[{\"status\":\"invalid\"},{\"status\":\"valid\"},{\"status\":\"invalid\"}]";
-        List<RowData> result = (List<RowData>) method.invoke(client, jsonArray.getBytes());
+        List<RowData> result = client.deserializeArray(jsonArray.getBytes());
 
         // THEN - only valid deserialization should be included
         assertThat(result).isNotNull();