Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how source maps are generated for testing #456

Closed
matthew-white opened this issue May 10, 2021 · 1 comment
Closed

Change how source maps are generated for testing #456

matthew-white opened this issue May 10, 2021 · 1 comment
Labels
infrastructure Changes to core libraries or setup testing Integration tests, unit tests

Comments

@matthew-white
Copy link
Member

In karma.conf.js, we specify inline-source-map for devtool. I think this is the value used in the karma-webpack readme. However, I noticed that the unit-mocha plugin for Vue CLI specifies inline-cheap-module-source-map. It looks like this is a little faster than inline-source-map, so maybe we should consider switching? Those source maps wouldn't include column information, but they would indicate source line numbers, which I think is all we need.

@matthew-white matthew-white added testing Integration tests, unit tests infrastructure Changes to core libraries or setup labels May 10, 2021
@matthew-white
Copy link
Member Author

We're going to be switching from Karma to Vitest as part of #671, so I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to core libraries or setup testing Integration tests, unit tests
Projects
None yet
Development

No branches or pull requests

1 participant