Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor frozen table columns #813

Open
matthew-white opened this issue May 26, 2023 · 0 comments
Open

Refactor frozen table columns #813

matthew-white opened this issue May 26, 2023 · 0 comments
Labels
refactor Improves code without altering behavior

Comments

@matthew-white
Copy link
Member

See #811 (comment). We have frozen columns in a few tables, but right now they involve a fair amount of complexity: see the TableFreeze component.

In terms of the user experience, I think there are accessibility concerns with the current implementation. The TableFreeze component renders two <table> elements, which I think would be difficult to navigate using a screen reader.

The linked comment suggests a couple of possible solutions.
@matthew-white matthew-white added the refactor Improves code without altering behavior label May 26, 2023
@matthew-white matthew-white mentioned this issue May 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Improves code without altering behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthew-white