Add Adb provider tests to CI

Exclude adb tests by path

Test

Test

Remove secrets for adb workflow

Fix exclude path

Test adb ci

test

test

Revert "test"

This reverts commit 85d90f2.

Fix PR suggestions

fix excluding adb test (require abs path)

test

Potential fix for code scanning alert no. 135: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Fix Adb test path

Add Android build-tools dir to PATH so aapt will be available

test

Author: tustanivsky

.github/workflows/app-runner.yml

@@ -1,4 +1,5 @@
 name: AppRunner
+permissions: read-all
 
 on:
   push:
@@ -18,4 +19,10 @@ jobs:
       module-name: SentryAppRunner
       module-path: app-runner
       test-path: Tests
+      exclude-path: Adb.Tests.ps1
       settings-path: PSScriptAnalyzerSettings.psd1
+
+  test-adb:
+    uses: ./.github/workflows/test-adb-provider.yml
+    with:
+      module-path: app-runner

.github/workflows/test-adb-provider.yml

@@ -0,0 +1,64 @@
+name: Test ADB Provider
+permissions:
+  contents: read
+
+on:
+  workflow_call:
+    inputs:
+      module-path:
+        description: 'Path to the module directory'
+        required: true
+        type: string
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: ${{ inputs.module-path }}
+        shell: pwsh
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Enable KVM group permissions
+        run: |
+          echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
+          sudo udevadm control --reload-rules
+          sudo udevadm trigger --name-match=kvm
+
+      - name: Setup Android directories
+        run: |
+          mkdir -p $HOME/.android/avd
+          touch $HOME/.android/repositories.cfg
+
+      - name: Install Android SDK Build Tools
+        shell: bash
+        run: |
+          ${ANDROID_HOME}/cmdline-tools/latest/bin/sdkmanager --install "build-tools;35.0.0"
+          echo "${ANDROID_HOME}/build-tools/35.0.0" >> $GITHUB_PATH
+
+      - name: Run ADB Provider Integration Tests
+        uses: reactivecircus/android-emulator-runner@d94c3fbe4fe6a29e4a5ba47c12fb47677c73656b
+        timeout-minutes: 45
+        with:
+          api-level: 35
+          target: 'google_apis'
+          arch: x86_64
+          force-avd-creation: true
+          disable-animations: true
+          disable-spellchecker: true
+          emulator-options: >
+            -no-window
+            -no-snapshot-save
+            -gpu swiftshader_indirect
+            -noaudio
+            -no-boot-anim
+            -camera-back none
+            -camera-front none
+          script: |
+            adb wait-for-device
+            echo "Android emulator is ready"
+            adb devices
+            cd ${{ inputs.module-path }} && pwsh -Command "Invoke-Pester Tests/Adb.Tests.ps1 -CI"

.github/workflows/test-powershell-module.yml

@@ -23,6 +23,11 @@ on:
         required: false
         type: string
         default: ''
+      exclude-path:
+        description: 'Comma-separated list of test file paths to exclude (relative to test-path)'
+        required: false
+        type: string
+        default: ''
       settings-path:
         description: 'Path to PSScriptAnalyzer settings file (relative to repo root)'
         required: false
@@ -98,6 +103,16 @@ jobs:
             $config.Filter.ExcludeTag = $excludeTags.Split(',').Trim()
           }
 
+          $excludePath = "${{ inputs.exclude-path }}"
+          if ($excludePath) {
+            $testPath = "${{ inputs.test-path }}"
+            $config.Run.ExcludePath = $excludePath.Split(',').Trim() | ForEach-Object {
+                $relativePath = Join-Path $testPath $_
+                # ExcludePath requires absolute paths
+                Join-Path (Get-Location) $relativePath
+            }
+          }
+
           $testResults = Invoke-Pester -Configuration $config
 
           Write-Host "Test Summary:" -ForegroundColor Cyan

app-runner/Private/DeviceProviders/AdbProvider.ps1

@@ -312,7 +312,7 @@ class AdbProvider : DeviceProvider {
                 $pidOutput = $this.InvokeCommand('pidof', @($this.DeviceSerial, $packageName))
 
                 if ($pidOutput) {
-                    $processId = $pidOutput.ToString().Trim()
+                    $processId = (@($pidOutput)[0]).ToString().Trim()
                     if ($processId -match '^\d+$') {
                         return $processId
                     }

app-runner/Tests/Adb.Tests.ps1

@@ -24,6 +24,9 @@ BeforeDiscovery {
 
     $TestTargets = @()
 
+    # Detect if running in CI environment
+    $isCI = $env:CI -eq 'true'
+
     # Check for ADB availability for AdbProvider
     if (Get-Command 'adb' -ErrorAction SilentlyContinue) {
         # Check if any devices are connected
@@ -32,11 +35,23 @@ BeforeDiscovery {
             $TestTargets += Get-TestTarget -Platform 'Adb'
         }
         else {
-            Write-Warning "No Android devices connected via ADB. AdbProvider tests will be skipped."
+            $message = "No Android devices connected via ADB"
+            if ($isCI) {
+                throw "$message. This is required in CI."
+            }
+            else {
+                Write-Warning "$message. AdbProvider tests will be skipped."
+            }
         }
     }
     else {
-        Write-Warning "ADB not found in PATH. AdbProvider tests will be skipped."
+        $message = "ADB not found in PATH"
+        if ($isCI) {
+            throw "$message. This is required in CI."
+        }
+        else {
+            Write-Warning "$message. AdbProvider tests will be skipped."
+        }
     }
 }
 
@@ -58,7 +73,7 @@ BeforeAll {
     }
 }
 
-Describe '<Platform>' -Tag 'RequiresDevice', 'Android' -ForEach $TestTargets {
+Describe '<Platform>' -Tag 'Adb' -ForEach $TestTargets {
     Context 'Device Connection Management' -Tag $TargetName {
         AfterEach {
             Invoke-TestCleanup

app-runner/Tests/SauceLabs.Tests.ps1

@@ -94,7 +94,7 @@ BeforeAll {
     }
 }
 
-Describe '<Platform>' -Tag 'RequiresDevice', 'SauceLabs' -ForEach $TestTargets {
+Describe '<Platform>' -Tag 'SauceLabs' -ForEach $TestTargets {
     Context 'Device Connection Management' -Tag $TargetName {
         AfterEach {
             Invoke-TestCleanup