-
-
Notifications
You must be signed in to change notification settings - Fork 7
Open
Labels
help wantedExtra attention is neededExtra attention is neededjsonschema-featureMissing fundamental support for a particular JSON schema featureMissing fundamental support for a particular JSON schema feature
Description
Addition of pattern or format should be a breaking change. Removal should not be.
Changing format to a different value should also be a breaking change. Not out of principle, but I think it is somewhat unlikely that one format is a subset of another. So this seems like the easiest thing to do.
But what about changing the value of pattern? We'd have to figure out whether the set of strings accepted by one regex is a subset of the strings accepted by another regex. Maybe the rust regex crate exposes the AST for that, but regexes in jsonschema are ECMAscript regexes. Maybe the saner way to go about this is to detect breaking changes using fuzzing or property testing.
An exciting research topic for sure.
domdomegg
Metadata
Metadata
Assignees
Labels
help wantedExtra attention is neededExtra attention is neededjsonschema-featureMissing fundamental support for a particular JSON schema featureMissing fundamental support for a particular JSON schema feature