Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish: getsentry/[email protected] #4530

Closed
3 tasks
getsentry-release opened this issue Oct 28, 2024 · 6 comments
Closed
3 tasks

publish: getsentry/[email protected] #4530

getsentry-release opened this issue Oct 28, 2024 · 6 comments
Labels
accepted Add to approve the deploy

Comments

@getsentry-release
Copy link

Requested by: @jamescrosswell

Merge target: auto-heap-dump

Quick links:

Assign the accepted label to this issue to approve the release.
Leave a comment containing #retract under this issue to retract the release (original issuer only).

Targets

  • nuget
  • github
  • registry

Targets marked with a checkbox have already been executed. Administrators can manually tick a checkbox to force craft to skip it.

@jamescrosswell
Copy link

jamescrosswell commented Oct 28, 2024

There seems to be a problem with the diff. It looks like a diff between the main branch and this branch. We asked for it to merge back into the auto-heap-dump branch (i.e. back into itself) so the only thing in the diff really should be the version number.

Possibly a problem with the action-prepare-release action. It doesn't look like the merge-target gets checked out prior to the release-git-info step unless inputs.craft_config_from_merge_target == 'true'. As a result, the release info is erroneously reading information from the main branch (not the merge-target branch).

@jamescrosswell
Copy link

#retract

@bruno-garcia
Copy link
Member

bruno-garcia commented Oct 28, 2024

Merge target: auto-heap-dump

Looks liek it will merge back on itself. The issue then is just the link generated for the diff

@bruno-garcia bruno-garcia added the accepted Add to approve the deploy label Oct 28, 2024
Copy link

Publishing: run#11563944414

@bruno-garcia
Copy link
Member

@jamescrosswell
Image
I imagine this doesn't work because u're not part of the sentry GitHub org. A guess though.

Copy link

Published successfully: run#11563944414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Add to approve the deploy
Projects
None yet
Development

No branches or pull requests

3 participants