fix(ui-tests): Fix duplicate accessibility identifiers and camera crashes (#6138)

Author: philprime

Samples/iOS-Swift/iOS-Swift-UITests/SessionReplayUITests.swift

@@ -2,12 +2,17 @@ import XCTest
 
 class SessionReplayUITests: BaseUITest {
 
-    func testCameraUI_shouldNotCrashOnIOS26() {
+    func testCameraUI_shouldNotCrashOnIOS26() throws {
+        guard UIImagePickerController.isSourceTypeAvailable(.camera) else {
+            throw XCTSkip("Camera UI is not available on this device.")
+        }
         // -- Arrange --
         // During the beta phase of iOS 26.0 we noticed crashes when traversing the view hierarchy
         // of the camera UI. This test is used to verify that no regression occurs.
         // See https://github.com/getsentry/sentry-cocoa/issues/5647
         app.buttons["Extra"].tap()
+
+        // -- Act --
         app.buttons["Show Camera UI"].tap()
 
         // We need to verify the camera UI is shown by checking for the existence of a UI element.
@@ -17,18 +22,12 @@ class SessionReplayUITests: BaseUITest {
         let cameraUIElement = app.buttons["PhotoCapture"]
         XCTAssertTrue(cameraUIElement.waitForExistence(timeout: 5))
 
-        // After the Camera UI is shown, we keep it open for 6 seconds to trigger at least one full
+        // After the Camera UI is shown, we keep it open for 10 seconds to trigger at least one full
         // video segment captured (segments are 5 seconds long).
-        wait(10)
+        delay(seconds: 10)
 
+        // -- Assert --
         // We know the test succeeded if we reach this point without the app crashing.
-    }
-
-    private func wait(_ seconds: TimeInterval) {
-        let exp = expectation(description: "Waiting for \(seconds) seconds")
-        DispatchQueue.main.asyncAfter(deadline: .now() + seconds) {
-            exp.fulfill()
-        }
-        wait(for: [exp], timeout: seconds + 1)
+        XCTAssertTrue(cameraUIElement.waitForExistence(timeout: 5))
     }
 }

Samples/iOS-Swift/iOS-Swift-UITests/XCTest+Delay.swift

@@ -0,0 +1,11 @@
+import XCTest
+
+public extension XCTestCase {
+    func delay(seconds: TimeInterval) {
+        let exp = expectation(description: "Waiting for \(seconds) seconds")
+        DispatchQueue.main.asyncAfter(deadline: .now() + seconds) {
+            exp.fulfill()
+        }
+        wait(for: [exp], timeout: seconds + 1)
+    }
+}

Samples/iOS-Swift/iOS-Swift/Base.lproj/Main.storyboard

@@ -1212,9 +1212,9 @@
                                                                     <segue destination="ehF-Y7-8St" kind="presentation" id="H7t-Et-KMM"/>
                                                                 </connections>
                                                             </button>
-                                                            <button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="system" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="4Dg-dP-BxN" userLabel="View Lifecycle Test">
+                                                            <button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="system" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="4Dg-dP-BxN" userLabel="Show Camera UI">
                                                                 <rect key="frame" x="0.0" y="448" width="160" height="28"/>
-                                                                <accessibility key="accessibilityConfiguration" identifier="view-lifecycle-test"/>
+                                                                <accessibility key="accessibilityConfiguration" identifier="show-camera-ui"/>
                                                                 <fontDescription key="fontDescription" type="system" pointSize="13"/>
                                                                 <inset key="imageEdgeInsets" minX="0.0" minY="0.0" maxX="2.2250738585072014e-308" maxY="0.0"/>
                                                                 <state key="normal" title="Show Camera UI"/>
@@ -1835,16 +1835,16 @@
             <color white="0.0" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
         </systemColor>
         <systemColor name="secondarySystemBackgroundColor">
-            <color red="0.94901960780000005" green="0.94901960780000005" blue="0.96862745100000003" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
+            <color red="0.94901960784313721" green="0.94901960784313721" blue="0.96862745098039216" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
         </systemColor>
         <systemColor name="systemBackgroundColor">
             <color white="1" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
         </systemColor>
         <systemColor name="systemGray5Color">
-            <color red="0.8980392157" green="0.8980392157" blue="0.91764705879999997" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
+            <color red="0.89803921568627454" green="0.89803921568627454" blue="0.91764705882352937" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
         </systemColor>
         <systemColor name="systemRedColor">
-            <color red="1" green="0.23137254900000001" blue="0.18823529410000001" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
+            <color red="1" green="0.23137254901960785" blue="0.18823529411764706" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
         </systemColor>
     </resources>
 </document>

Samples/iOS-Swift/iOS-Swift/ExtraViewController.swift

@@ -414,6 +414,13 @@ class ExtraViewController: UIViewController {
     }
 
     @IBAction func showCameraUIAction(_ sender: Any) {
+        // We need to check if the camera is available, otherwise simulators running on a Mac Mini (device without any
+        // built-in camera) would crash with this error:
+        //
+        // *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Source type 1 not available'
+        guard UIImagePickerController.isSourceTypeAvailable(.camera) else {
+            preconditionFailure("Can not display the camera UI because the source type is not available.")
+        }
         let imagePicker = UIImagePickerController()
         imagePicker.sourceType = .camera
         imagePicker.allowsEditing = false