Changes for major version 9 #2946
Replies: 11 comments 3 replies
-
Integration installation. Per #2941, we dynamically construct integrations based on a list of strings representing their class names. This technically allows for customers to inject their own custom integration classes. It's not clear if this should be supported, how it would work, or what benefit customers can gain from doing so. The dynamic strategy also discards type safety. We should not do so for the sake of our own convenience. We should figure out a way to do this with a simple API that doesn't rely on stringly typed logic. It should be enough for the boolean properties already present on SentryOptions to control which integrations are enabled or disabled. From there we can have a static code sector that sets things up. No need for looping through strings, using |
Beta Was this translation helpful? Give feedback.
-
Rename SentryMechanismMeta to something else different than Meta. See #2888 for discussion. |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
Found a |
Beta Was this translation helpful? Give feedback.
-
Remove obsoleted public methods in |
Beta Was this translation helpful? Give feedback.
-
Update sentry-cocoa/.github/workflows/test.yml Line 92 in 3de9971 as that's what's supported in GitHub actions: https://github.com/actions/runner-images/blob/91e422a825d3941ea357a13a91b13d4f4fdc326d/images/macos/macos-11-Readme.md?plain=1#L272 |
Beta Was this translation helpful? Give feedback.
-
Make sampleRate / tracesSampleRate / profilesSampleRate / SentryTracesSamplerCallback nonnull: #3529 (comment) |
Beta Was this translation helpful? Give feedback.
-
Remove the deprecated |
Beta Was this translation helpful? Give feedback.
-
Remove the deprecated |
Beta Was this translation helpful? Give feedback.
-
Change |
Beta Was this translation helpful? Give feedback.
-
Remove the public access to SentryHub.scope. The scope should only be accessible by customers via SentryHub.scope has a property getter override that contains a If it is imperative to protect the thread safety of the property, we should extract it into its own objc interface that keeps the instance private and only exposes a method to access it in a synchronized way. This would make all callsites that use the scope that require waiting on a lock more obvious that that is what is happening. |
Beta Was this translation helpful? Give feedback.
-
Let's discuss the breaking changes we'd like to see that are waiting on the next major version, à la #877 and #1094
Beta Was this translation helpful? Give feedback.
All reactions