Skip to content

Commit c32dfbb

Browse files
BreadcrumbLevel Critical renamed to Fatal (#4605)
Resolves #4028: - #4028
1 parent ac5b47b commit c32dfbb

28 files changed

+41
-39
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
### BREAKING CHANGES
66

7+
- `BreadcrumbLevel.Critical` has been renamed to `BreadcrumbLevel.Fatal` for consistency with the other Sentry SDKs ([#4605](https://github.com/getsentry/sentry-dotnet/pull/4605))
78
- SentryOptions.IsEnvironmentUser now defaults to false on MAUI. The means the User.Name will no longer be set, by default, to the name of the device ([#4606](https://github.com/getsentry/sentry-dotnet/pull/4606))
89
- Remove unnecessary files from SentryCocoaFramework before packing ([#4602](https://github.com/getsentry/sentry-dotnet/pull/4602))
910
- ScopeExtensions.Populate is now internal ([#4611](https://github.com/getsentry/sentry-dotnet/pull/4611))

benchmarks/Sentry.Benchmarks/BreadcrumbOverheadBenchmarks.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class BreadcrumbOverheadBenchmarks
1111
{
1212
{ Message, Type }
1313
};
14-
private const BreadcrumbLevel Level = BreadcrumbLevel.Critical;
14+
private const BreadcrumbLevel Level = BreadcrumbLevel.Fatal;
1515

1616
private IDisposable _sdk;
1717

samples/Sentry.Samples.Console.Customized/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ await SentrySdk.ConfigureScopeAsync(async scope =>
6666
const string replaceBreadcrumb = "don't trust this breadcrumb";
6767
if (hint.Items.TryGetValue(replaceBreadcrumb, out var replacementMessage))
6868
{
69-
return new Breadcrumb((string)replacementMessage, null, null, null, BreadcrumbLevel.Critical);
69+
return new Breadcrumb((string)replacementMessage, null, null, null, BreadcrumbLevel.Fatal);
7070
}
7171

7272
return crumb;

src/Sentry.Extensions.Logging/LogLevelExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public static BreadcrumbLevel ToBreadcrumbLevel(this LogLevel level)
1313
LogLevel.Information => BreadcrumbLevel.Info,
1414
LogLevel.Warning => BreadcrumbLevel.Warning,
1515
LogLevel.Error => BreadcrumbLevel.Error,
16-
LogLevel.Critical => BreadcrumbLevel.Critical,
16+
LogLevel.Critical => BreadcrumbLevel.Fatal,
1717
_ => (BreadcrumbLevel)level
1818
};
1919
}

src/Sentry.Log4Net/LevelMapping.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ internal static class LevelMapping
2020
{
2121
return loggingLevel.Level switch
2222
{
23-
var l when l == Level.Fatal || l == Level.Emergency => BreadcrumbLevel.Critical,
23+
var l when l == Level.Fatal || l == Level.Emergency => BreadcrumbLevel.Fatal,
2424
var l when l == Level.Alert || l == Level.Critical || l == Level.Severe || l == Level.Error => BreadcrumbLevel.Error,
2525
var l when l == Level.Warn => BreadcrumbLevel.Warning,
2626
var l when l == Level.Notice || l == Level.Info => BreadcrumbLevel.Info,

src/Sentry.NLog/LogLevelExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public static BreadcrumbLevel ToBreadcrumbLevel(this LogLevel level)
2222
{
2323
nameof(LogLevel.Debug) => BreadcrumbLevel.Debug,
2424
nameof(LogLevel.Error) => BreadcrumbLevel.Error,
25-
nameof(LogLevel.Fatal) => BreadcrumbLevel.Critical,
25+
nameof(LogLevel.Fatal) => BreadcrumbLevel.Fatal,
2626
nameof(LogLevel.Info) => BreadcrumbLevel.Info,
2727
nameof(LogLevel.Trace) => BreadcrumbLevel.Debug,
2828
nameof(LogLevel.Warn) => BreadcrumbLevel.Warning,

src/Sentry.Serilog/LogLevelExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public static BreadcrumbLevel ToBreadcrumbLevel(this LogEventLevel level)
3838
LogEventLevel.Information => BreadcrumbLevel.Info,
3939
LogEventLevel.Warning => BreadcrumbLevel.Warning,
4040
LogEventLevel.Error => BreadcrumbLevel.Error,
41-
LogEventLevel.Fatal => BreadcrumbLevel.Critical,
41+
LogEventLevel.Fatal => BreadcrumbLevel.Fatal,
4242
_ => (BreadcrumbLevel)level
4343
};
4444
}

src/Sentry/Breadcrumb.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,9 @@ public static Breadcrumb FromJson(JsonElement json)
165165
"INFO" => BreadcrumbLevel.Info,
166166
"WARNING" => BreadcrumbLevel.Warning,
167167
"ERROR" => BreadcrumbLevel.Error,
168-
"CRITICAL" => BreadcrumbLevel.Critical,
169-
"FATAL" => BreadcrumbLevel.Critical,
168+
// Renamed in v6 but kept here to avoid issues with cached envelopes. Can be safely removed in the future.
169+
"CRITICAL" => BreadcrumbLevel.Fatal,
170+
"FATAL" => BreadcrumbLevel.Fatal,
170171
_ => default
171172
};
172173
return new Breadcrumb(timestamp, message, type, data!, category, level);

src/Sentry/BreadcrumbLevel.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ public enum BreadcrumbLevel
3333
Error = 2,
3434

3535
/// <summary>
36-
/// Critical breadcrumb level.
36+
/// Fatal breadcrumb level.
3737
/// </summary>
38-
[EnumMember(Value = "critical")]
39-
Critical = 3,
38+
[EnumMember(Value = "fatal")]
39+
Fatal = 3,
4040
}

src/Sentry/Internal/Hub.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,7 @@ private void AddBreadcrumbForException(SentryEvent evt, Scope scope)
501501
{"exception_message", exceptionMessage}
502502
};
503503
}
504-
scope.AddBreadcrumb(breadcrumbMessage, "Exception", data: data, level: BreadcrumbLevel.Critical);
504+
scope.AddBreadcrumb(breadcrumbMessage, "Exception", data: data, level: BreadcrumbLevel.Fatal);
505505
}
506506
catch (Exception e)
507507
{

0 commit comments

Comments
 (0)