Skip to content

Commit 653d878

Browse files
kamilogorekHazAT
authored andcommitted
test: Fix fingerprint tests for core (#1745)
* test: Fix fingerprint tests for core * test: Fix unit tests with new tslib build
1 parent 503f51d commit 653d878

File tree

4 files changed

+19
-7
lines changed

4 files changed

+19
-7
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
## 4.3.1
66

7-
- [browser] ref: Breadcrumbs will no be logged only to a max object depth of 2
7+
- [browser] ref: Breadcrumbs will now be logged only to a max object depth of 2
88
- [core] feat: Filter internal Sentry errors from transports/sdk
99
- [core] ref: Better fingerprint handling
1010
- [node] ref: Expose Parsers functions

packages/browser/test/karma/karma.unit.config.js

+8-1
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,15 @@ module.exports = config => {
1414
karmaTypescriptConfig: {
1515
tsconfig: 'tsconfig.json',
1616
compilerOptions: {
17-
declaration: false,
1817
allowJs: true,
18+
declaration: false,
19+
paths: {
20+
'@sentry/utils/*': ['../../utils/src/*'],
21+
'@sentry/core': ['../../core/src'],
22+
'@sentry/hub': ['../../hub/src'],
23+
'@sentry/types': ['../../types/src'],
24+
'@sentry/minimal': ['../../minimal/src'],
25+
},
1926
},
2027
bundlerOptions: {
2128
sourceMap: true,

packages/core/test/lib/base.test.ts

+8-2
Original file line numberDiff line numberDiff line change
@@ -174,11 +174,10 @@ describe('BaseClient', () => {
174174
values: [
175175
{
176176
type: 'Error',
177-
value: 'random error',
177+
value: 'test exception',
178178
},
179179
],
180180
},
181-
message: 'Error: test exception',
182181
});
183182
});
184183

@@ -188,6 +187,7 @@ describe('BaseClient', () => {
188187
await client.captureMessage('test message', undefined, undefined, scope);
189188
expect(TestBackend.instance!.event).toEqual({
190189
event_id: '42',
190+
fingerprint: ['test message'],
191191
message: 'test message',
192192
});
193193
});
@@ -215,6 +215,7 @@ describe('BaseClient', () => {
215215
expect(TestBackend.instance!.event!.message).toBe('message');
216216
expect(TestBackend.instance!.event).toEqual({
217217
event_id: '42',
218+
fingerprint: ['message'],
218219
message: 'message',
219220
});
220221
});
@@ -229,6 +230,7 @@ describe('BaseClient', () => {
229230
expect(TestBackend.instance!.event!).toEqual({
230231
environment: 'env',
231232
event_id: '42',
233+
fingerprint: ['message'],
232234
message: 'message',
233235
});
234236
});
@@ -242,6 +244,7 @@ describe('BaseClient', () => {
242244
await client.captureEvent({ message: 'message' }, undefined, scope);
243245
expect(TestBackend.instance!.event!).toEqual({
244246
event_id: '42',
247+
fingerprint: ['message'],
245248
message: 'message',
246249
release: 'v1.0.0',
247250
});
@@ -255,6 +258,7 @@ describe('BaseClient', () => {
255258
expect(TestBackend.instance!.event!).toEqual({
256259
breadcrumbs: [{ message: 'breadcrumb' }],
257260
event_id: '42',
261+
fingerprint: ['message'],
258262
message: 'message',
259263
});
260264
});
@@ -268,6 +272,7 @@ describe('BaseClient', () => {
268272
expect(TestBackend.instance!.event!).toEqual({
269273
breadcrumbs: [{ message: '2' }],
270274
event_id: '42',
275+
fingerprint: ['message'],
271276
message: 'message',
272277
});
273278
});
@@ -282,6 +287,7 @@ describe('BaseClient', () => {
282287
expect(TestBackend.instance!.event!).toEqual({
283288
event_id: '42',
284289
extra: { b: 'b' },
290+
fingerprint: ['message'],
285291
message: 'message',
286292
tags: { a: 'a' },
287293
user: { id: 'user' },

packages/core/test/mocks/backend.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,11 @@ export class TestBackend extends BaseBackend<TestOptions> {
2929
exception: {
3030
values: [
3131
{
32-
type: 'Error',
33-
value: 'random error',
32+
type: exception.name,
33+
value: exception.message,
3434
},
3535
],
3636
},
37-
message: String(exception),
3837
};
3938
}
4039

0 commit comments

Comments
 (0)