Skip to content

Commit 7072a48

Browse files
committed
Frames are no longer dropped
1 parent 2aa255d commit 7072a48

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

packages/browser/test/tracekit/chromium.test.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,7 @@ describe('Tracekit - Chrome Tests', () => {
617617
});
618618
});
619619

620-
it('should drop frames that are over 1kb', () => {
620+
it('should truncate frames that are over 1kb', () => {
621621
const LONG_STR = 'A'.repeat(1040);
622622

623623
const LONG_FRAME = {
@@ -637,6 +637,12 @@ describe('Tracekit - Chrome Tests', () => {
637637
stacktrace: {
638638
frames: [
639639
{ filename: 'http://localhost:5000/', function: '?', lineno: 50, colno: 19, in_app: true },
640+
{
641+
filename:
642+
'http://localhost:5000/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA',
643+
function: 'Foo.testMethod',
644+
in_app: true,
645+
},
640646
{ filename: 'http://localhost:5000/', function: 'aha', lineno: 39, colno: 5, in_app: true },
641647
],
642648
},

packages/core/src/utils/node-stack-trace.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export function node(getModule?: GetModuleFn): StackLineParserFn {
6262
return {
6363
filename: `<data:${dataUriMatch[2]}>`,
6464
function: dataUriMatch[1],
65-
}
65+
};
6666
}
6767

6868
const lineMatch = line.match(FULL_MATCH);

packages/core/test/lib/utils/stacktrace.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,8 @@ describe('node', () => {
382382
});
383383

384384
it('parses function name when filename is a data uri ', () => {
385-
const input = 'at dynamicFn (data:application/javascript,export function dynamicFn() { throw new Error(\'Error from data-uri module\');};:1:38)';
385+
const input =
386+
"at dynamicFn (data:application/javascript,export function dynamicFn() { throw new Error('Error from data-uri module');};:1:38)";
386387

387388
const expectedOutput = {
388389
function: 'dynamicFn',

0 commit comments

Comments
 (0)