Skip to content

Fork/vendor remix instrumentation #15739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mydea opened this issue Mar 19, 2025 · 3 comments · Fixed by #16145
Closed

Fork/vendor remix instrumentation #15739

mydea opened this issue Mar 19, 2025 · 3 comments · Fixed by #16145
Assignees
@onurtemizkan
Labels
Remix

Comments

@mydea
Copy link
Member

mydea commented Mar 19, 2025

Description

We use https://github.com/justindsmith/opentelemetry-instrumentations-js/tree/main/packages/instrumentation-remix, which is not heavily maintained.

Since we'll have to bump this to OTEL v2 soon, we should inline this, which will also make it much easier to keep dependencies in sync (which is basically impossible today because this is not frequently bumped). We should of course make sure to properly attribute this to the original implementor.
@lforst lforst self-assigned this Mar 20, 2025
@mydea mydea removed the Task label Apr 14, 2025
@mydea mydea added the Remix label Apr 14, 2025 — with Linear
@lforst
Copy link
Contributor

lforst commented Apr 16, 2025

@onurtemizkan is this maybe something you could take a look at?

@onurtemizkan
Copy link
Collaborator

Yes, sure 👍

@onurtemizkan onurtemizkan self-assigned this Apr 16, 2025
@onurtemizkan onurtemizkan mentioned this issue Apr 28, 2025
Merged
AbhiPrasad pushed a commit that referenced this issue May 13, 2025
@onurtemizkan
feat(remix): Vendor in opentelemetry-instrumentation-remix (#16145)
b998433 
Resolves: #15739

- Removed Remix v1-related instrumentation code from the original
implementation while vendoring in.

- Also, FormData entries for manual instrumentation are aligned with
OTEL use.
Resolves: #16140
@github-actions GitHub Actions
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #16145, which was included in the 9.19.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onurtemizkan onurtemizkan

Labels
Remix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(remix): Vendor in opentelemetry-instrumentation-remix getsentry/sentry-javascript
4 participants
@mydea @onurtemizkan @stephanie-anderson @lforst