Merge remote-tracking branch 'origin/master' into kddubey/issue-summary/thresholds-possible-cause-frontend

Author: kddubey

migrations_lockfile.txt

@@ -15,7 +15,7 @@ remote_subscriptions: 0003_drop_remote_subscription
 
 replays: 0004_index_together
 
-sentry: 0822_alert_rule_always_organization
+sentry: 0823_projectcodeowners_raw_never_null
 
 social_auth: 0002_default_auto_field
 

pyproject.toml

@@ -118,7 +118,6 @@ ignore_missing_imports = true
 module = [
     "sentry.api.base",
     "sentry.api.bases.organization_events",
-    "sentry.api.endpoints.codeowners",
     "sentry.api.endpoints.event_attachments",
     "sentry.api.endpoints.group_integration_details",
     "sentry.api.endpoints.group_integrations",

requirements-dev-frozen.txt

@@ -186,7 +186,7 @@ sentry-cli==2.16.0
 sentry-covdefaults-disable-branch-coverage==1.0.2
 sentry-devenv==1.14.2
 sentry-forked-django-stubs==5.1.2.post1
-sentry-forked-djangorestframework-stubs==3.15.2.post1
+sentry-forked-djangorestframework-stubs==3.15.2.post2
 sentry-forked-email-reply-parser==0.5.12.post1
 sentry-kafka-schemas==1.0.2
 sentry-ophio==1.0.0

requirements-dev.txt

@@ -39,7 +39,7 @@ packaging>=21.3
 
 # for type checking
 sentry-forked-django-stubs>=5.1.2.post1
-sentry-forked-djangorestframework-stubs>=3.15.2.post1
+sentry-forked-djangorestframework-stubs>=3.15.2.post2
 lxml-stubs
 msgpack-types>=0.2.0
 mypy>=1.14

src/sentry/api/bases/organization.py

@@ -661,12 +661,10 @@ def has_release_permission(
         actor_id = None
         has_perms = None
         key = None
-        if getattr(request, "user", None) and request.user.id:
+        if request.user.is_authenticated:
             actor_id = "user:%s" % request.user.id
-        if getattr(request, "auth", None) and getattr(request.auth, "id", None):
-            actor_id = "apikey:%s" % request.auth.id  # type: ignore[union-attr]
-        elif getattr(request, "auth", None) and getattr(request.auth, "entity_id", None):
-            actor_id = "apikey:%s" % request.auth.entity_id  # type: ignore[union-attr]
+        elif request.auth is not None:
+            actor_id = "apikey:%s" % request.auth.entity_id
         if actor_id is not None:
             requested_project_ids = project_ids
             if requested_project_ids is None:

src/sentry/api/client.py

@@ -4,6 +4,7 @@
 
 import orjson
 from django.conf import settings
+from django.contrib.auth.models import AnonymousUser
 from django.urls import resolve
 from rest_framework.test import APIRequestFactory, force_authenticate
 
@@ -79,7 +80,7 @@ def request(
                 mock_request.superuser = Superuser(mock_request)
         else:
             mock_request.auth = auth
-            mock_request.user = user
+            mock_request.user = user or AnonymousUser()
             mock_request.is_sudo = lambda: is_sudo
             mock_request.session = {}
             mock_request.superuser = Superuser(mock_request)

src/sentry/api/endpoints/codeowners/__init__.py

@@ -20,7 +20,7 @@
 from .analytics import *  # NOQA
 
 
-class ProjectCodeOwnerSerializer(CamelSnakeModelSerializer):
+class ProjectCodeOwnerSerializer(CamelSnakeModelSerializer[ProjectCodeOwners]):
     code_mapping_id = serializers.IntegerField(required=True)
     raw = serializers.CharField(required=True)
     organization_integration_id = serializers.IntegerField(required=False)
@@ -114,9 +114,9 @@ def update(
         if "id" in validated_data:
             validated_data.pop("id")
         for key, value in validated_data.items():
-            setattr(self.instance, key, value)
-        self.instance.save()
-        return self.instance
+            setattr(instance, key, value)
+        instance.save()
+        return instance
 
 
 class ProjectCodeOwnersMixin:

src/sentry/api/endpoints/codeowners/index.py

@@ -32,9 +32,6 @@ def refresh_codeowners_schema(self, codeowner: ProjectCodeOwners, project: Proje
         ):
             return
 
-        if codeowner.raw is None:
-            return
-
         # Convert raw to issue owners syntax so that the schema can be created
         raw = codeowner.raw
         associations, _ = validate_codeowners_associations(codeowner.raw, project)

src/sentry/api/endpoints/group_ai_summary.py

@@ -33,12 +33,18 @@
 from rest_framework.request import Request
 
 
+class SummarizeIssueScores(BaseModel):
+    possible_cause_confidence: float
+    possible_cause_novelty: float
+
+
 class SummarizeIssueResponse(BaseModel):
     group_id: str
     headline: str
     whats_wrong: str | None = None
     trace: str | None = None
     possible_cause: str | None = None
+    scores: SummarizeIssueScores | None = None
 
 
 @region_silo_endpoint

src/sentry/api/endpoints/release_deploys.py

@@ -124,13 +124,12 @@ def post(self, request: Request, organization, version) -> Response:
         if not self.has_release_permission(request, organization, release):
             # Logic here copied from `has_release_permission` (lightly edited for results to be more
             # human-readable)
-            auth = None
-            if getattr(request, "user", None) and request.user.id:
+            if request.user.is_authenticated:
                 auth = f"user.id: {request.user.id}"
-            elif getattr(request, "auth", None) and getattr(request.auth, "id", None):
-                auth = f"auth.id: {request.auth.id}"  # type: ignore[union-attr]
-            elif getattr(request, "auth", None) and getattr(request.auth, "entity_id", None):
-                auth = f"auth.entity_id: {request.auth.entity_id}"  # type: ignore[union-attr]
+            elif request.auth is not None:
+                auth = f"auth.entity_id: {request.auth.entity_id}"
+            else:
+                auth = None
             if auth is not None:
                 logging_info.update({"auth": auth})
                 logger.info(