Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX improvements in Search #731

Open
1 of 3 tasks
Shubhdeep12 opened this issue Mar 8, 2025 · 2 comments
Open
1 of 3 tasks

UX improvements in Search #731

Shubhdeep12 opened this issue Mar 8, 2025 · 2 comments
Labels
help wanted Extra attention is needed Package: Overlay Type: Enhancement New feature or request

Comments

@Shubhdeep12
Copy link
Collaborator

Shubhdeep12 commented Mar 8, 2025 •
edited by BYK
Loading

  • Should make the search bar sticky at the top for long/deep trees.
  • We should have an actual filtering functionality, not just highlight
  • We may wanna look into creating a query language of sorts or at least chaining filters with negation etc.

Originally posted by @BYK in #730 (review)
@BYK BYK added Type: Enhancement New feature or request help wanted Extra attention is needed Package: Overlay labels Mar 10, 2025
@Shubhdeep12 Shubhdeep12 mentioned this issue Mar 22, 2025
Merged
2 tasks
@betegon betegon mentioned this issue Mar 24, 2025
Open
2 tasks
@Shubhdeep12
Copy link
Collaborator Author

Can we allow both highlighting and filtering of matched spans, giving users an option to toggle "Show Only Matched" after search?

Both approaches serve the purpose of searching in different ways.

@BYK
Copy link
Member

BYK commented Mar 25, 2025

Agreed, one will be filter and the other would be search. Related: #745

BYK pushed a commit that referenced this issue Mar 25, 2025
@Shubhdeep12
Trace Detail Page improvements (#740)
a8f6323 
- Added a generic Resizer and extend its usage to SpanResizer and TreeResizer.
- Fixed Overflow styling across overlay.
- Refs #731.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed Package: Overlay Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BYK @Shubhdeep12