R52.beta discussion

[ddTech]

Good morning Greg,

how about adding a flag isRawData (better / other name welcome) to the class that is being set by openXLSXWorkbook() and openXLSXWorkbookEx() accordingly?

I added a protected property _isRawData as well as isRawData with an access method to my R52.beta

This now allows for dual use of methods like .GetLastRowNumber()

LPARAMETERS tnWB, tnSh
LOCAL ARRAY laMaxRow[1]
IF PCOUNT() < 2
	RETURN .NULL.
ENDIF

if this._isRawData
	SELECT MAX(row) FROM xl_sheetcells ;
		WHERE workbook = tnWB ;
			AND sheet = tnSh ;
		INTO ARRAY laMaxRow
else
	SELECT MAX(row) FROM xl_cells ;
		WHERE workbook = tnWB ;
			AND sheet = tnSh ;
			AND celldeleted = False ;
		INTO ARRAY laMaxRow
endif		

IF  _TALLY > 0 .AND. VARTYPE(laMaxRow[1]) = "N"
	RETURN laMaxRow[1]
ELSE
	RETURN 0
ENDIF

Other methods could redirect to the appropriate ones ( .getCellValue -> .getCellValueEx() ), return valid information or simply inform the developer that the useage is not possible in this or the other context.

Regards

Frank

[ggreen86]

I see your point for the new property. I will put it on the "burner" as a to-do item. Right now, my time is limited due to my actual contract work schedule.

[ggreen86]

Frank— Some thoughts on the property isRawData. If this is implemented as a property, then it would have to be switched back-n-forth to use with a ‘raw’ sheet load vs. a ‘full’ sheet load which to me would be cumbersome. I think that this could be added as an optional parameter to the methods that is defaulted to False. This way it is more direct as to what is being passed and expected to be returned at the code of the method call. So, GetLastRowNumber() would be: LPARAMETERS tnWB, tnSh, tlRawData LOCAL ARRAY laMaxRow[1] DO CASE CASE PCOUNT() < 2 RETURN .NULL. CASE PCOUNT() = 2 tlRawData = .F. ENDCASE tlRawData = NVL(tlRawData, .F.) if tlRawData SELECT MAX(row) FROM xl_sheetcells ; WHERE workbook = tnWB ; AND sheet = tnSh ; INTO ARRAY laMaxRow else SELECT MAX(row) FROM xl_cells ; WHERE workbook = tnWB ; AND sheet = tnSh ; AND celldeleted = False ; INTO ARRAY laMaxRow endif IF _TALLY > 0 .AND. VARTYPE(laMaxRow[1]) = "N" RETURN laMaxRow[1] ELSE RETURN 0 ENDIF What is the purpose of having a protected property instead of the normal property? With only an access method, how is this implemented for isRawData? Purpose? Greg From: ddTech ***@***.***> Sent: Wednesday, October 29, 2025 6:32 AM To: ggreen86/XLSX-Workbook-Class ***@***.***> Cc: Subscribed ***@***.***> Subject: [ggreen86/XLSX-Workbook-Class] R52.beta discussion (Issue #147) [Image removed by sender.]ddTech created an issue (ggreen86/XLSX-Workbook-Class#147)<#147> Good morning Greg, how about adding a flag isRawData (better / other name welcome) to the class that is being set by openXLSXWorkbook() and openXLSXWorkbookEx() accordingly? I added a protected property _isRawData as well as isRawData with an access method to my R52.beta This now allows for dual use of methods like .GetLastRowNumber() LPARAMETERS tnWB, tnSh LOCAL ARRAY laMaxRow[1] IF PCOUNT() < 2 RETURN .NULL. ENDIF if this._isRawData SELECT MAX(row) FROM xl_sheetcells ; WHERE workbook = tnWB ; AND sheet = tnSh ; INTO ARRAY laMaxRow else SELECT MAX(row) FROM xl_cells ; WHERE workbook = tnWB ; AND sheet = tnSh ; AND celldeleted = False ; INTO ARRAY laMaxRow endif IF _TALLY > 0 .AND. VARTYPE(laMaxRow[1]) = "N" RETURN laMaxRow[1] ELSE RETURN 0 ENDIF Other methods could redirect to the appropriate ones ( .getCellValue -> .getCellValueEx() ), return valid information or simply inform the developer that the useage is not possible in this or the other context. Regards Frank — Reply to this email directly, view it on GitHub<#147>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGWB33II2E32B62OLDUFG5T32CJSDAVCNFSM6AAAAACKREMJA2VHI2DSMVQWIX3LMV43ASLTON2WKOZTGU3DKMZRGMZDMOI>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ddTech]

Greg,

Some thoughts on the property isRawData. If this is implemented as a property, then it would have to be
switched back-n-forth to use with a ‘raw’ sheet load vs. a ‘full’ sheet load which to me would be cumbersome.
... What is the purpose of having a protected property instead of the normal property?
With only an access method, how is this implemented for isRawData? Purpose?

hm.. ,right, my bad.
First, I probably was not clear enaugh about my concept
Second, The idea was based on an incorrect assumption.

I had the idea that You could only deal with one workbook at at time exlusively as the cursor names are fixed.
But now I have realized that You can indeed open additional workbooks which then simply counts up the workbook id.
That makes the idea the way it was intended kind of obsolete.

The idea behind the proteced property was that it's not to be set by the developer, but by .openXLSXWorkbook() and . openXLSXWorkbookEx() like

LPARAMETERS tcFileName, tnSh, tlGetFml, tnBegRow, tnBegCol, tnEndRow, tnEndCol
LOCAL lcTempPath, lcXmlPath, lcFile, lcStrings, loStrings, lcString, lcElement, lnNode, lnWB
LOCAL ARRAY laFile[1]

this._isRawData = .T.

DO CASE
	CASE PCOUNT() = 0
		this.ErrorLevelId = 1...

The access method was intended for readOnly access from outside.

But if I can deal with one file via openXLSXWorkbook and with another one opened with the Ex() variant a method like .getLastRowNumber() is unable to know which of them I am currently addressing.

Maybe via the workbook-ID and a lookup table (xl_workbooks) ?
No... it seems hat only workbooks opened with openXLSXWorkbook() are being added to the xl_workbooks cursor.
And if I open one file with openXLSXWorkbook() and a second one with openXLSXWorkbookEx(), both get workbook-ID 1

Yes, additional parameters could be a way but I think with all these cursors and references the class should know which are the appropriate sources ...

I see, this gets more complicated than it seemed at first sight.
Nevermind You've got other work to do. Sorry for the bother.

Frank

[ggreen86]

Frank— I actually have some time in between my work. My ‘real’ job is an SAP consultant and I am currently downloading very large tables for being able to create test data; this is slowwww… As such, I am double tasking… I would still go back to the idea of using a parameter with it defaulting to the ‘normal’ cursor results or using separate methods (just more methods to maintain). The separate methods with the ‘Ex’ suffix makes a distinction between the methods and less likely to get these mixed. Thoughts. Greg From: ddTech ***@***.***> Sent: Wednesday, October 29, 2025 3:24 PM To: ggreen86/XLSX-Workbook-Class ***@***.***> Cc: ggreen86 ***@***.***>; Comment ***@***.***> Subject: Re: [ggreen86/XLSX-Workbook-Class] R52.beta discussion (Issue #147) [Image removed by sender.]ddTech left a comment (ggreen86/XLSX-Workbook-Class#147)<#147 (comment)> Greg, Some thoughts on the property isRawData. If this is implemented as a property, then it would have to be switched back-n-forth to use with a ‘raw’ sheet load vs. a ‘full’ sheet load which to me would be cumbersome. ... What is the purpose of having a protected property instead of the normal property? With only an access method, how is this implemented for isRawData? Purpose? hm.. ,right, my bad. First, I probably was not clear enaugh about my concept Second, The idea was based on an incorrect assumption. I had the idea that You could only deal with one workbook at at time exlusively as the cursor names are fixed. But now I have realized that You can indeed open additional workbooks which then simply counts up the workbook id. That makes the idea the way it was intended kind of obsolete. The idea behind the proteced property was that it's not to be set by the developer, but by .openXLSXWorkbook() and . openXLSXWorkbookEx() like LPARAMETERS tcFileName, tnSh, tlGetFml, tnBegRow, tnBegCol, tnEndRow, tnEndCol LOCAL lcTempPath, lcXmlPath, lcFile, lcStrings, loStrings, lcString, lcElement, lnNode, lnWB LOCAL ARRAY laFile[1] this._isRawData = .T. DO CASE CASE PCOUNT() = 0 this.ErrorLevelId = 1... The access method was intended for readOnly access from outside. But if I can deal with one file via openXLSXWorkbook and with another one opened with the Ex() variant a method like .getLastRowNumber() is unable to know which of them I am currently addressing. Maybe via the workbook-ID and a lookup table (xl_workbooks) ? No... it seems hat only workbooks opened with openXLSXWorkbook() are being added to the xl_workbooks cursor. And if I open one file with openXLSXWorkbook() and a second one with openXLSXWorkbookEx(), both get workbook-ID 1 Yes, additional parameters could be a way but I think with all these cursors and references the class should know which are the appropriate sources ... I see, this gets more complicated than it seemed at first sight. Nevermind You've got other work to do. Sorry for the bother. Frank — Reply to this email directly, view it on GitHub<#147 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGWB33PUBCUI5AFSBXFH6S332EH4DAVCNFSM6AAAAACKREMJA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINRTGQ2TSOJTGM>. You are receiving this because you commented.Message ID: ***@***.***>

[ddTech]

Greg,

I actually have some time in between my work ... I would still go back to the idea of using a parameter with it defaulting to the ‘normal’ cursor results or using separate methods (just more methods to maintain)....

I think both ways are well doable. The Ex()-approach would make a clear distinction between the two worlds.
On the other hand there already are lots of methods in this class which can be somewhat intimidating even if same method names with and without Ex()-suffix does not add much complexity.
The parameter approach asks for a bit more understanding of the two concepts on the developer side.

With Ex() you'd have to if-branch in your own functions that shall be used for both variants. A parameter would be more handy especially as You would probably call these functions with a correspoonding parameter. But actually does not make too much of a difference.

I think I'd slightly favor the parameter.

Frank