Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triple-clicking empty line and dragging does not set selection start #4957

Closed
mitchellh opened this issue Jan 11, 2025 · 3 comments
Closed

Triple-clicking empty line and dragging does not set selection start #4957

mitchellh opened this issue Jan 11, 2025 · 3 comments

Comments

@mitchellh
Copy link
Contributor

Discussed in #4938

Reproduction

  1. cat README.md (Ghostty's works)
  2. Triple click any blank line
  3. Drag up or down
@otomist
Copy link
Contributor

otomist commented Jan 13, 2025

I'll pick this up

@otomist otomist mentioned this issue Jan 14, 2025
Merged
@otomist
Copy link
Contributor

otomist commented Jan 14, 2025

Opened a PR at #5068 which should fix this.

Tested on:
OS: Pop 22.04 jammy
Shell: bash 5.1.16
Resolution: 2560x1440
WM: Awesome

triple-drag-fix.mov

mitchellh added a commit that referenced this issue Jan 20, 2025
@mitchellh
Fix triple clicking empty line and dragging (#5068)
f8ece63 
Fixes core issue #4957. Adds a bool to `SelectLine` allowing the
`selectLine` function to select lines that are empty. When starting a
triple selection on an empty line the initial `selectLine` returns null
because we don't see any characters, in this case we rerun `selectLine`
but short circuit with the `allow_empty_lines`. We need to run
`selectLine` with out allowing empty lines once because if there are
characters on the line we don't want to select empty space.
@injust
Copy link
Collaborator

injust commented Jan 23, 2025

This was fixed by #5068 (I don't have permissions to close this issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mitchellh @injust @otomist