Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Cloned assignments do not follow deadline restriction #119

Open
Chris-Johnston opened this issue Dec 25, 2018 · 10 comments
Open

Cloned assignments do not follow deadline restriction #119

Chris-Johnston opened this issue Dec 25, 2018 · 10 comments

Comments

@Chris-Johnston
Copy link
Contributor

When cloning the repos for an assignment with a set deadline, each will have the latest commit checked out by default, and not the latest commit before this deadline.

Steps to reproduce:

  1. Create a new assignment with a deadline.
  2. Create a new submission to this assignment, with at least one commit.
  3. Wait for the deadline to pass.
  4. Alter the submission.
  5. Clone the assignment. The cloned copy will be checked out to the latest commit, and not the latest commit before the deadline.
@joel-coffman
Copy link

Ditto. What's the point of cloning locally if the only way to check what was completed by the deadline is using the web interface?

It would be nice to see a tag or signed commit so that the final commit prior to the deadline is (permanently) part of the repository. Without this feature, I see no value to the Classroom Assistant, at least for assignments with due dates.

@srinjoym
Copy link
Contributor

srinjoym commented Jun 5, 2019

This is a great idea! I think this is definitely a feature we can add but it will require some changes on the API from the Classroom Web side. @mozzadrella this could be a good starter issue for the new interns!

@kevinkwl
Copy link

any updates?

@pisanuw
Copy link

pisanuw commented Oct 4, 2019

I ask students to submit the hashtag of the last commit to our LMS which does enforce assignment deadlines and then have to do

git clone student-repository
cd student-repository
git checkout HASH

@cgokce
Copy link

cgokce commented Nov 22, 2019

I can still reproduce this issue. Can you fix this? Deadline feature is useless unless it is integrated with the assistant app.

@femmebot
Copy link

femmebot commented Dec 2, 2019

+1 on behalf of another teacher who gave similar feedback during a recent research interview.

@mrsimonsen
Copy link

Don't let this this issue die, this would be an extremely useful feature.

@maxwenger
Copy link

+1 Bump. This would make it way easier to adopt.

@fuhrmanator
Copy link

For now, the workaround I am recommending to my TAs is to run Classroom Assistant right after the deadline, so clones happen appropriately.

Can anyone clarify if the "Submission" feature described at https://github.blog/2017-08-23-github-classroom-now-supports-deadlines-and-class-rosters/ is still valid (or is it irrelevant with CA)?

@etiennebeaulac
Copy link

+1 here too, this feature would be really useful!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests