Merge pull request #18457 from hvitved/dataflow/disallowed-return-inline-late

Data flow: Fix a bad join order

Author: hvitved

shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll

@@ -595,12 +595,18 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
       }
 
       pragma[nomagic]
-      private ReturnKindExtOption getDisallowedReturnKind(ParamNodeEx p) {
+      private ReturnKindExtOption getDisallowedReturnKind0(ParamNodeEx p) {
         if allowParameterReturnInSelfEx(p)
         then result.isNone()
         else p.isParameterOf(_, result.asSome().(ParamUpdateReturnKind).getPosition())
       }
 
+      bindingset[p]
+      pragma[inline_late]
+      private ReturnKindExtOption getDisallowedReturnKind(ParamNodeEx p) {
+        result = getDisallowedReturnKind0(p)
+      }
+
       /**
        * Holds if an argument to `call` is reached in the flow covered by `fwdFlow`.
        */