Update rust/ql/lib/codeql/rust/elements/internal/VariableImpl.qll

geoffw0 · paldepind · web-flow · commit 18ce8be3024b · 2024-11-06T19:00:10.000Z
Co-authored-by: Simon Friis Vindum &lt;paldepind@github.com&gt;
diff --git a/rust/ql/lib/codeql/rust/elements/internal/VariableImpl.qll b/rust/ql/lib/codeql/rust/elements/internal/VariableImpl.qll
@@ -88,7 +88,7 @@ module Impl {
     // exclude parameters from functions without a body as these are trait method declarations
     // without implementations
     not exists(Function f | not f.hasBody() and f.getParamList().getAParam().getPat() = p) and
-    // exclude parameters from function pointers as well, which also lack a body
+    // exclude parameters from function pointer types (e.g. `x` in `fn(x: i32) -> i32`)
     not exists(FnPtrType fp | fp.getParamList().getParam(_).getPat() = p)
   }
 

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ module Impl {`
`88`	`88`	`// exclude parameters from functions without a body as these are trait method declarations`
`89`	`89`	`// without implementations`
`90`	`90`	`not exists(Function f \| not f.hasBody() and f.getParamList().getAParam().getPat() = p) and`
`91`		`- // exclude parameters from function pointers as well, which also lack a body`
	`91`	+ // exclude parameters from function pointer types (e.g. `x` in `fn(x: i32) -> i32`)
`92`	`92`	`not exists(FnPtrType fp \| fp.getParamList().getParam(_).getPat() = p)`
`93`	`93`	`}`
`94`	`94`