Skip to content

Commit 203cf92

Browse files
michaelnebelmichaelnebel
committed
C#: Move bad testcases into dedicated test file.
1 parent 26074b0 commit 203cf92

File tree

3 files changed

+76
-77
lines changed

3 files changed

+76
-77
lines changed

‎csharp/ql/test/query-tests/Dead Code/DeadStoreOfLocal/DeadStoreOfLocal.cs

+54
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,60 @@
11
using System;
22
using System.Collections.Generic;
33

4+
class Bad
5+
{
6+
double ParseInt(string s)
7+
{
8+
var success = int.TryParse(s, out int i); // $ Alert
9+
return i;
10+
}
11+
12+
bool IsDouble(string s)
13+
{
14+
var success = double.TryParse(s, out double i);
15+
return success;
16+
}
17+
18+
double ParseDouble(string s)
19+
{
20+
try
21+
{
22+
return double.Parse(s);
23+
}
24+
catch (FormatException e) // $ Alert
25+
{
26+
return double.NaN;
27+
}
28+
}
29+
30+
int Count(string[] ss)
31+
{
32+
int count = 0;
33+
foreach (var s in ss) // $ Alert
34+
count++;
35+
return count;
36+
}
37+
38+
string IsInt(object o)
39+
{
40+
if (o is int i) // $ Alert
41+
return "yes";
42+
else
43+
return "no";
44+
}
45+
46+
string IsString(object o)
47+
{
48+
switch (o)
49+
{
50+
case string s: // $ Alert
51+
return "yes";
52+
default:
53+
return "no";
54+
}
55+
}
56+
}
57+
458
public class DeadStoreOfLocal
559
{
660
delegate int D();

‎csharp/ql/test/query-tests/Dead Code/DeadStoreOfLocal/DeadStoreOfLocal.expected

+22-22
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
1-
| DeadStoreOfLocal.cs:12:13:12:20 | Int32 x = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:12:13:12:13 | x | x |
2-
| DeadStoreOfLocal.cs:19:21:19:25 | ... = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:18:13:18:13 | x | x |
3-
| DeadStoreOfLocal.cs:44:13:44:20 | Int32 x = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:44:13:44:13 | x | x |
4-
| DeadStoreOfLocal.cs:50:9:50:14 | ... = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:49:13:49:13 | x | x |
5-
| DeadStoreOfLocal.cs:56:9:56:11 | ...++ | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:55:13:55:13 | x | x |
6-
| DeadStoreOfLocal.cs:82:22:82:24 | String val | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:82:22:82:24 | val | val |
7-
| DeadStoreOfLocal.cs:101:13:101:37 | ... = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:94:40:94:44 | extra | extra |
8-
| DeadStoreOfLocal.cs:104:13:104:37 | ... = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:94:16:94:20 | info1 | info1 |
9-
| DeadStoreOfLocal.cs:142:26:142:27 | Exception ex | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:142:26:142:27 | ex | ex |
10-
| DeadStoreOfLocal.cs:246:17:246:24 | Int32 y = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:246:17:246:17 | y | y |
11-
| DeadStoreOfLocal.cs:261:17:261:21 | Int32 x = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:261:17:261:17 | x | x |
12-
| DeadStoreOfLocal.cs:300:23:300:28 | Object v1 | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:300:27:300:28 | v1 | v1 |
13-
| DeadStoreOfLocal.cs:314:18:314:23 | Object v2 | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:314:22:314:23 | v2 | v2 |
14-
| DeadStoreOfLocal.cs:331:9:331:32 | ... = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:327:23:327:23 | b | b |
15-
| DeadStoreOfLocal.cs:372:13:372:20 | String s = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:372:13:372:13 | s | s |
16-
| DeadStoreOfLocal.cs:398:13:398:21 | ... = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:396:13:396:13 | s | s |
17-
| DeadStoreOfLocal.cs:472:20:472:76 | FileStream y = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:472:20:472:20 | y | y |
18-
| DeadStoreOfLocalBad.cs:7:13:7:48 | Boolean success = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocalBad.cs:7:13:7:19 | success | success |
19-
| DeadStoreOfLocalBad.cs:23:32:23:32 | FormatException e | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocalBad.cs:23:32:23:32 | e | e |
20-
| DeadStoreOfLocalBad.cs:32:22:32:22 | String s | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocalBad.cs:32:22:32:22 | s | s |
21-
| DeadStoreOfLocalBad.cs:39:18:39:22 | Int32 i | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocalBad.cs:39:22:39:22 | i | i |
22-
| DeadStoreOfLocalBad.cs:49:18:49:25 | String s | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocalBad.cs:49:25:49:25 | s | s |
1+
| DeadStoreOfLocal.cs:8:13:8:48 | Boolean success = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:8:13:8:19 | success | success |
2+
| DeadStoreOfLocal.cs:24:32:24:32 | FormatException e | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:24:32:24:32 | e | e |
3+
| DeadStoreOfLocal.cs:33:22:33:22 | String s | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:33:22:33:22 | s | s |
4+
| DeadStoreOfLocal.cs:40:18:40:22 | Int32 i | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:40:22:40:22 | i | i |
5+
| DeadStoreOfLocal.cs:50:18:50:25 | String s | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:50:25:50:25 | s | s |
6+
| DeadStoreOfLocal.cs:66:13:66:20 | Int32 x = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:66:13:66:13 | x | x |
7+
| DeadStoreOfLocal.cs:73:21:73:25 | ... = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:72:13:72:13 | x | x |
8+
| DeadStoreOfLocal.cs:98:13:98:20 | Int32 x = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:98:13:98:13 | x | x |
9+
| DeadStoreOfLocal.cs:104:9:104:14 | ... = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:103:13:103:13 | x | x |
10+
| DeadStoreOfLocal.cs:110:9:110:11 | ...++ | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:109:13:109:13 | x | x |
11+
| DeadStoreOfLocal.cs:136:22:136:24 | String val | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:136:22:136:24 | val | val |
12+
| DeadStoreOfLocal.cs:155:13:155:37 | ... = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:148:40:148:44 | extra | extra |
13+
| DeadStoreOfLocal.cs:158:13:158:37 | ... = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:148:16:148:20 | info1 | info1 |
14+
| DeadStoreOfLocal.cs:196:26:196:27 | Exception ex | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:196:26:196:27 | ex | ex |
15+
| DeadStoreOfLocal.cs:300:17:300:24 | Int32 y = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:300:17:300:17 | y | y |
16+
| DeadStoreOfLocal.cs:315:17:315:21 | Int32 x = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:315:17:315:17 | x | x |
17+
| DeadStoreOfLocal.cs:354:23:354:28 | Object v1 | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:354:27:354:28 | v1 | v1 |
18+
| DeadStoreOfLocal.cs:368:18:368:23 | Object v2 | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:368:22:368:23 | v2 | v2 |
19+
| DeadStoreOfLocal.cs:385:9:385:32 | ... = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:381:23:381:23 | b | b |
20+
| DeadStoreOfLocal.cs:426:13:426:20 | String s = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:426:13:426:13 | s | s |
21+
| DeadStoreOfLocal.cs:452:13:452:21 | ... = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:450:13:450:13 | s | s |
22+
| DeadStoreOfLocal.cs:526:20:526:76 | FileStream y = ... | This assignment to $@ is useless, since its value is never read. | DeadStoreOfLocal.cs:526:20:526:20 | y | y |

‎csharp/ql/test/query-tests/Dead Code/DeadStoreOfLocal/DeadStoreOfLocalBad.cs

-55
This file was deleted.

0 commit comments

Comments
 (0)