JS: Add pre-existing expectations

Author: asgerf

javascript/ql/test/library-tests/UnderlyingTypes/calls.ts

@@ -3,7 +3,7 @@ import * as express from 'express';
 function getRequest(): express.Request { }
 
 function t1() {
-    getRequest(); // $ hasUnderlyingType='express'.Request
+    getRequest(); // $ MISSING: hasUnderlyingType='express'.Request
 }
 
 declare function getRequestAmbient(): express.Request;
@@ -17,16 +17,16 @@ class C {
 }
 
 function t3(c: C) {
-    c.method(); // $ hasUnderlyingType='express'.Request
-    new C().method(); // $ hasUnderlyingType='express'.Request
+    c.method(); // $ MISSING: hasUnderlyingType='express'.Request
+    new C().method(); // $ MISSING: hasUnderlyingType='express'.Request
 }
 
 function callback(fn: (req: express.Request) => void) { // $ SPURIOUS: hasUnderlyingType='express'.Request - req seems to be a SourceNode
 }
 
 function t4() {
     callback(function (
-        req // $ hasUnderlyingType='express'.Request
+        req // $ MISSING: hasUnderlyingType='express'.Request
     ) { }
     );
 }

javascript/ql/test/library-tests/UnderlyingTypes/expressBulkExport.use.ts

@@ -1,7 +1,7 @@
 import { Request, Response } from './expressBulkExport';
 
-function t1(req: Request) { // $ hasUnderlyingType='express'.Request
+function t1(req: Request) { // $ MISSING: hasUnderlyingType='express'.Request SPURIOUS: hasUnderlyingType='expressBulkExport.ts'.Request
 }
 
-function t2(res: Response) { // $ hasUnderlyingType='express'.Response
+function t2(res: Response) { // $ MISSING: hasUnderlyingType='express'.Response SPURIOUS: hasUnderlyingType='expressBulkExport.ts'.Response
 }

javascript/ql/test/library-tests/UnderlyingTypes/expressExportAssign.use.ts

@@ -1,4 +1,4 @@
 import { Request } from "./expressExportAssign";
 
-function t1(req: Request) { // $ hasUnderlyingType='express'.Request
+function t1(req: Request) { // $ MISSING: hasUnderlyingType='express'.Request SPURIOUS: hasUnderlyingType='expressExportAssign.ts'.Request
 }

javascript/ql/test/library-tests/UnderlyingTypes/expressExportAssignWrapper.use.ts

@@ -1,4 +1,4 @@
 import { E } from "./expressExportAssignWrapper";
 
-function t1(req: E.Request) { // $ hasUnderlyingType='express'.Request
+function t1(req: E.Request) { // $ MISSING: hasUnderlyingType='express'.Request
 }

javascript/ql/test/library-tests/UnderlyingTypes/expressSelectiveExport.use.ts

@@ -1,10 +1,10 @@
 import { Request, Response, R } from './expressSelectiveExport';
 
-function t1(req: Request) { // $ hasUnderlyingType='express'.Request
+function t1(req: Request) { // $ MISSING: hasUnderlyingType='express'.Request SPURIOUS: hasUnderlyingType='expressSelectiveExport.ts'.Request
 }
 
-function t2(res: Response) { // none, not exported
+function t2(res: Response) { // $ SPURIOUS: hasUnderlyingType='expressSelectiveExport.ts'.Response - none, not exported
 }
 
-function t3(res: R) { // $ hasUnderlyingType='express'.Response
+function t3(res: R) { // $ MISSING: hasUnderlyingType='express'.Response SPURIOUS: hasUnderlyingType='expressSelectiveExport.ts'.R
 }

javascript/ql/test/library-tests/UnderlyingTypes/expressWrapperExport.use.ts

@@ -1,29 +1,29 @@
 import { Request, Response, wrapper } from './expressWrapperExport';
 import * as w from './expressWrapperExport';
 
-function t1(req: Request) { // none
+function t1(req: Request) { // $ SPURIOUS: hasUnderlyingType='expressWrapperExport.ts'.Request - none
 }
 
-function t2(res: Response) { // none
+function t2(res: Response) { // $ SPURIOUS: hasUnderlyingType='expressWrapperExport.ts'.Response - none
 }
 
-function t3(req: wrapper.Request) { // $ hasUnderlyingType='express'.Request
+function t3(req: wrapper.Request) { // $ MISSING: hasUnderlyingType='express'.Request
 }
 
-function t4(res: wrapper.Response) { // $ hasUnderlyingType='express'.Response
+function t4(res: wrapper.Response) { // $ MISSING: hasUnderlyingType='express'.Response
 }
 
-function t5(req: w.wrapper.Request) { // $ hasUnderlyingType='express'.Request
+function t5(req: w.wrapper.Request) { // $ MISSING: hasUnderlyingType='express'.Request
 }
 
-function t6(res: w.wrapper.Response) { // $ hasUnderlyingType='express'.Response
+function t6(res: w.wrapper.Response) { // $ MISSING: hasUnderlyingType='express'.Response
 }
 
-function t7(req: w.Request) { // none
+function t7(req: w.Request) { // $ SPURIOUS: hasUnderlyingType='expressWrapperExport.ts'.Request - none
 }
 
-function t8(res: w.Response) { // none
+function t8(res: w.Response) { // $ SPURIOUS: hasUnderlyingType='expressWrapperExport.ts'.Response - none
 }
 
-function t9(e: typeof w.wrapper) { // $ hasUnderlyingType='express'
+function t9(e: typeof w.wrapper) { // $ MISSING: hasUnderlyingType='express'
 }

javascript/ql/test/library-tests/UnderlyingTypes/jsdoc.js

@@ -4,11 +4,11 @@ import { Response } from 'express';
 /**
  * @param {e.Request} req
  */
-function t1(req) { // $ hasUnderlyingType='express'.Request SPURIOUS: hasUnderlyingType=e.Request
+function t1(req) { // $ MISSING: hasUnderlyingType='express'.Request SPURIOUS: hasUnderlyingType=e.Request
 }
 
 /**
  * @param {Response} res
  */
-function t2(res) { // $ hasUnderlyingType='express'.Response SPURIOUS: hasUnderlyingType=Response
+function t2(res) { // $ MISSING: hasUnderlyingType='express'.Response SPURIOUS: hasUnderlyingType=Response
 }

javascript/ql/test/library-tests/UnderlyingTypes/namespaceDecls.ts

@@ -11,17 +11,17 @@ namespace C {
     export const A = E;
 }
 
-function t1(x: A.E.Request) { // $ hasUnderlyingType='express'.Request
+function t1(x: A.E.Request) { // $ MISSING: hasUnderlyingType='express'.Request
 }
 
-function t2(x: B.Q.E.Request) { // $ hasUnderlyingType='express'.Request
+function t2(x: B.Q.E.Request) { // $ MISSING: hasUnderlyingType='express'.Request
 }
 
-function t3(x: typeof Express) { // $ hasUnderlyingType='express'
+function t3(x: typeof Express) { // $ MISSING: hasUnderlyingType='express'
 }
 
-function t4(x: typeof A.E) { // $ hasUnderlyingType='express'
+function t4(x: typeof A.E) { // $ MISSING: hasUnderlyingType='express'
 }
 
-function t5(x: typeof C.A) { // $ hasUnderlyingType='express'
+function t5(x: typeof C.A) { // $ MISSING: hasUnderlyingType='express'
 }

javascript/ql/test/library-tests/UnderlyingTypes/namespaceImport.ts

@@ -1,15 +1,15 @@
 import * as express from 'express';
 
-function t1(e: typeof express) { // $ hasUnderlyingType='express'
+function t1(e: typeof express) { // $ MISSING: hasUnderlyingType='express'
 }
 
 function t2(req: express.Request) { // $ hasUnderlyingType='express'.Request
 }
 
-function t3(req: Request) { // none, not in scope
+function t3(req: Request) { // $ SPURIOUS: hasUnderlyingType=Body hasUnderlyingType=Request - none, not in scope
 }
 
 type E = typeof express;
 
-function t4(e: E) { // $ hasUnderlyingType='express'
+function t4(e: E) { // $ MISSING: hasUnderlyingType='express'
 }

javascript/ql/test/library-tests/UnderlyingTypes/props.ts

@@ -6,11 +6,11 @@ interface Foo {
 }
 
 function t1(f: Foo) {
-    f.req; // $ hasUnderlyingType='express'.Request
-    f.e; // $ hasUnderlyingType='express'
+    f.req; // $ MISSING: hasUnderlyingType='express'.Request
+    f.e; // $ MISSING: hasUnderlyingType='express'
 
     const {
-        req, // $ hasUnderlyingType='express'.Request
-        e // $ hasUnderlyingType='express'
+        req, // $ MISSING: hasUnderlyingType='express'.Request
+        e // $ MISSING: hasUnderlyingType='express'
     } = f;
 }