JS: Support unqualified jsdoc names

Author: asgerf

javascript/ql/lib/semmle/javascript/Variables.qll

@@ -27,6 +27,12 @@ class Scope extends @scope {
     result = this.getAVariable() and
     result.getName() = name
   }
+
+  /** Gets the local type name with the given name declared in this scope. */
+  LocalTypeName getLocalTypeName(string name) {
+    result.getScope() = this and
+    result.getName() = name
+  }
 }
 
 /**

javascript/ql/lib/semmle/javascript/internal/TypeResolution.qll

@@ -132,6 +132,12 @@ module TypeResolution {
       node1 = type.getExpressionName() and
       node2 = type
     )
+    or
+    exists(JSDocNamedTypeExpr type, string name |
+      type.hasNameParts(name, "") and
+      node1 = type.getTopLevel().getScope().getLocalTypeName(name) and
+      node2 = type
+    )
   }
 
   /**

javascript/ql/test/library-tests/UnderlyingTypes/jsdoc.js

@@ -10,5 +10,5 @@ function t1(req) { // $ hasUnderlyingType='express'.Request SPURIOUS: hasUnderly
 /**
  * @param {Response} res
  */
-function t2(res) { // $ MISSING: hasUnderlyingType='express'.Response SPURIOUS: hasUnderlyingType=Response
+function t2(res) { // $ hasUnderlyingType='express'.Response SPURIOUS: hasUnderlyingType=Response
 }