Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.3.0 broke the UX of text-expander (for me) #77

Open
StanBright opened this issue Nov 15, 2023 · 1 comment
Open

v2.3.0 broke the UX of text-expander (for me) #77

StanBright opened this issue Nov 15, 2023 · 1 comment

Comments

@StanBright
Copy link

StanBright commented Nov 15, 2023 •
edited
Loading

A quick report that v2.3.0 and the new scrollIntoView broke the UX of @github/text-expander for me. It would push the expanded <ul> to the top of the screen. After spending a few hours debugging what's the core of the issue, I noticed that the undesirable UX happens after the combobox-nav dependency of text-expander is upgraded to v2.3.0.

If someone else is facing this issue, my solution was to fix combobox-nav to v2.2.0 through "resolutions" section of package.json.
@wxiaoguang
Copy link
Contributor

It should have been fixed by #79 , v2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StanBright @wxiaoguang