Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify: "The audit command is only supported when using an organization account." #34237

Closed
1 task done
jsoref opened this issue Aug 7, 2024 · 5 comments · Fixed by #34682
Closed
1 task done

clarify: "The audit command is only supported when using an organization account." #34237

jsoref opened this issue Aug 7, 2024 · 5 comments · Fixed by #34682
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR

Comments

@jsoref
Copy link
Contributor

jsoref commented Aug 7, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/migrating-to-github-actions/automated-migrations/migrating-from-circleci-with-github-actions-importer#limitations

What part(s) of the article would you like to see updated?

  • The audit command is only supported when using an organization account. However, the dry-run and migrate commands can be used with an organization or user account.

There are two platforms involved in migrating from circleci to GitHub:

  1. circleci
  2. GitHub

It is not clear whether this bullet point is talking about the former or the latter. If it's talking about the latter, it should really have explain how/where to provide an "organization account". If it's talking about the former, it should do the same. -- I've been a user of github for a fairly long time and while I am an owner of many organizations, I can't figure out what this would mean in github terms. organization-accounts are things in github, but you can't log in with them -- you log in as a user that is a member of an organization.

Additional information

No response

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Aug 7, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 7, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 7, 2024
@nguyenalex836
Copy link
Contributor

@jsoref Thanks for opening an issue! I'll get this triaged for review ✨

@felicitymay
Copy link
Contributor

Hi @jsoref 👋🏻

  • The audit command is only supported when using an organization account. However, the dry-run and migrate commands can be used with an organization or user account.
    There are two platforms involved in migrating from circleci to GitHub:
  1. circleci
  2. GitHub

It is not clear whether this bullet point is talking about the former or the latter. If it's talking about the latter, it should really have explain how/where to provide an "organization account". If it's talking about the former, it should do the same. -- I've been a user of github for a fairly long time and while I am an owner of many organizations, I can't figure out what this would mean in github terms. organization-accounts are things in github, but you can't log in with them -- you log in as a user that is a member of an organization.

I agree that the bullet point that you've highlighted is unclear.

I can confirm that the bullet is referring to use of the GitHub Actions Importer. It sounds as if you need to be a GitHub user who is part of an organization to create a PAT that can be used to run the audit command, but this is worth checking on. I'm going to request an SME review to get clarity on this.

@felicitymay felicitymay added the needs SME This proposal needs review from a subject matter expert label Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836
Copy link
Contributor

@jsoref Thank you for your patience while our SME team reviewed! 💛 They confirmed CircleCI organization accounts are being referenced here.

We should update the doc to be explicit that the following phrase is talking about CircleCI accounts:

  • The audit command is only supported when using an organization account. However, the dry-run and migrate commands can be used with an organization or user account.

Would be clearer as:

  • The audit command is only supported when you use a CircleCI organization account. The dry-run and migrate commands can be used with a CircleCI organization or user account.

I've added the help wanted label so that you, or anyone else, may open a PR for this update ✨ thanks again for raising this issue!

@nguyenalex836 nguyenalex836 added help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@felicitymay @jsoref @nguyenalex836 and others