Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected context window sizes for o1-preview and o1-mini models #34912

Closed
wants to merge 2 commits into from

Conversation

carloshvp
Copy link
Contributor

@carloshvp carloshvp commented Oct 12, 2024

The correct values are taken from the official models pages: https://github.com/marketplace/models/azure-openai/o1-preview https://github.com/marketplace/models/azure-openai/o1-mini

Why:

Closes: #34911

What's being changed (if available, include any code snippets, screenshots, or gifs):

Corrected context window sizes, according to official model pages referred
https://github.com/marketplace/models/azure-openai/o1-preview
https://github.com/marketplace/models/azure-openai/o1-mini

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Oct 12, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 12, 2024
Copy link
Contributor

github-actions bot commented Oct 12, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
github-models/prototyping-with-ai-models.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team github models Content relating to GitHub models waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 14, 2024
@nguyenalex836
Copy link
Contributor

@carloshvp Thanks so much for opening a PR! I'll get this triaged for review ✨

@subatoi subatoi added the needs SME This proposal needs review from a subject matter expert label Oct 15, 2024
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@matthewisabel
Copy link
Contributor

Thanks for suggesting this change. I think we need to make our docs clearer as these are the service limits when the service is provided without costs on GitHub Models. While the models do support a larger context window, the service constrains the number of tokens when users are using the free service. I'll make a future docs PR to make the clearer around this table.

@carloshvp
Copy link
Contributor Author

Thank you @matthewisabel for the clarification. Should I close this PR then?

@nguyenalex836
Copy link
Contributor

@carloshvp I'll go ahead and close this 💛 Thank you so much for your willingness to contribute to our docs!

If you're looking for an issue to pick up, take a look at our help wanted section to find open issues you can work on ✨

@nguyenalex836 nguyenalex836 added SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team github models Content relating to GitHub models SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model context sizes for o1-preview and o1-mini are incorrect
5 participants