`moda-ci.yaml` triggers an error in forks for anyone who doesn't have access to github/docs-internal #35731

jsoref · 2024-12-20T13:25:17Z

This guard

Line 39 in 190a7a5

if: ${{ github.repository == 'github/docs-internal' }}

did not prevent:
Invalid workflow file: .github/workflows/moda-ci.yaml#L86

error parsing called workflow
".github/workflows/moda-ci.yaml"
-> "github/internal-actions/.github/workflows/docker_security.yml@main"
: workflow was not found. See https://docs.github.com/actions/learn-github-actions/reusing-workflows#access-to-reusable-workflows for more information.

I think it might be possible to avoid this structure by using a combination of a workflow_call with a jobs: / if: condition that guards against the user from tripping on the problem e.g. ${{ github.repository == 'github/docs-internal' }} and then have the on: workflow_call on the internal side be responsible for using the reusable workflow.

Originally posted by @jsoref in #34562 (comment)

The text was updated successfully, but these errors were encountered:

nguyenalex836 · 2024-12-20T18:38:21Z

@jsoref Thank you for raising the flag on this! ✨ Given the referenced file, I'll create an issue to have this reviewed internally 💛

I'll close this issue, but if you find anything else that might be relevant, feel free to ping me here and I'll copy over to the internal issue!

docs-bot · 2024-12-20T18:38:45Z

Thank you for opening this issue! Updates to this documentation must be made internally. I have copied your issue to an internal issue, so I will close this issue.

jsoref · 2025-03-07T21:50:20Z

Here's a quick sample of forks wasting resources on this

Based on the first page of results in https://github.com/search?q=path%3A.github%2Fworkflows%2Fmoda-ci.yaml+is%3Afork&type=code:

github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 20, 2024

jsoref mentioned this issue Dec 20, 2024

document some of the pitfalls of using private or internal reusable workflows in a public repo #35735

Closed

1 task

nguyenalex836 closed this as completed Dec 20, 2024

nguyenalex836 added content This issue or pull request belongs to the Docs Content team fix-internally Triggers a workflow to copy the issue internally and close the current issue and removed triage Do not begin working on this issue until triaged by the team labels Dec 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`moda-ci.yaml` triggers an error in forks for anyone who doesn't have access to github/docs-internal #35731

`moda-ci.yaml` triggers an error in forks for anyone who doesn't have access to github/docs-internal #35731

jsoref commented Dec 20, 2024

nguyenalex836 commented Dec 20, 2024

docs-bot commented Dec 20, 2024

jsoref commented Mar 7, 2025

moda-ci.yaml triggers an error in forks for anyone who doesn't have access to github/docs-internal #35731

moda-ci.yaml triggers an error in forks for anyone who doesn't have access to github/docs-internal #35731

Comments

jsoref commented Dec 20, 2024

nguyenalex836 commented Dec 20, 2024

docs-bot commented Dec 20, 2024

jsoref commented Mar 7, 2025

`moda-ci.yaml` triggers an error in forks for anyone who doesn't have access to github/docs-internal #35731

`moda-ci.yaml` triggers an error in forks for anyone who doesn't have access to github/docs-internal #35731