Image alignment not respected in reStructuredText

[jkleint]

If I try to right-align an image in reStructuredText:

.. image:: https://travis-ci.org/jkleint/blamethrower.png
  :align: right

It comes out left-aligned: https://github.com/jkleint/blamethrower/blob/master/README.rst

[jone]

python-creole, which seems to be used for rest2html, does not support it at the moment.
I've made a fix & pull-request to jedie/python-creole#11 for fixing it.

[jedie]

python-creole is IMHO not used here. See: https://github.com/github/markup/blob/master/lib/github/commands/rest2html

[jone]

oh, my bad. I assumed it is used here.
I'm gonna look into it.

[gjtorikian]

Align is deprecated in HTML5: http://stackoverflow.com/questions/14551305/align-attribute-deprecated

[flying-sheep]

This bug is not fixed, :align: right has no impact on the emitted HTML, which is wrong. please reopen

[bmorris3]

I think this is still an issue. Any help?

[Gallaecio]

Align is deprecated in HTML5: http://stackoverflow.com/questions/14551305/align-attribute-deprecated

@gjtorikian reStructuredText’s align is not HTML, is reStructuredText syntax. And it is not deprecated (emphasis mine):

The alignment of the image, equivalent to the HTML tag's deprecated "align" attribute or the corresponding "vertical-align" and "text-align" CSS properties. The values "top", "middle", and "bottom" control an image's vertical alignment (relative to the text baseline); they are only useful for inline images (substitutions). The values "left", "center", and "right" control an image's horizontal alignment, allowing the image to float and have the text flow around it. The specific behavior depends upon the browser or rendering software used.

[gjtorikian]

I don’t work at GitHub anymore, please contact their support.

[Gallaecio]

@kivikakk Any chance you could reopen this issue?

[flying-sheep]

#1222 is an old attempt by me to fix this, and I assume it didn’t fix this because of gjtorikian/html-pipeline#302. Not entirely sure if that’s still the case.

We just need someone at GitHub to start caring at some point.

[kivikakk]

I also don't work at GitHub anymore, sorry; contacting support remains your best option.

[Gallaecio]

@kivikakk Sorry, I saw your commits were the most recent, I did not realize they were from more than 1 year ago.

I wonder if GitHub is even maintaining this anymore.

[Gallaecio]

@aharpole Could we reopen this issue?

[StefanBogdan]

I am experiencing the same problem. The README.rst does not take into account the :align: or :width: for me. But if I use the same README.rst as a long description for PyPI it is rendered exactly as I want. I think this should be reopened too.

[trevorld]

In case people aren't aware of this workaround note Github does however respect align="right" within an html <img> tag contained within a restructuredText raw:: html directive e.g.

.. raw:: html

   <img src="figures/logo.png" align="right" width="300px" alt="right-aligned logo in README">

does work even if the equivalent rst image directive unfortunately does not:

.. image:: figures/logo.png
  :align: right
  :width: 300
  :alt: right-aligned logo in README

[bmorris3]

The align feature in rst seems to be working now! See example here.

[waldyrious]

The align feature in rst seems to be working now! See example here.

At last! I assume this was fixed by #1452.

[jmi2k]

The align feature in rst seems to be working now! See example here.

It doesn't work for me using a PNG file, either a local one or an URL.

[flying-sheep]

Does work for us: https://github.com/scverse/anndata#readme

It's a SVG, but I'm unsure how this could be relevant.

[Gallaecio]

Both the linked examples work on my browsers (latest Firefox, latest Chromium).

[jmi2k]

Here you have a gist showcasing both cases https://gist.github.com/jmi2k/f422df7d4a67dde9c19e74d091c3582e.

[Gallaecio]

Here you have a gist showcasing both cases https://gist.github.com/jmi2k/f422df7d4a67dde9c19e74d091c3582e.

Interesting, the PNG one does not seem to get align="right" there.