fix: address review feedback - NopCommand repo arg, milestones mock, teams test error propagation

Co-authored-by: decyjphr <57544838+decyjphr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/safe-settings/sessions/d9420b15-2cca-40a3-a30b-869df73487f1

Author: Copilot

lib/plugins/repository.js

@@ -125,7 +125,7 @@ module.exports = class Repository extends ErrorStash {
               const options = { template_owner: this.repo.owner, template_repo: this.template, owner: this.repo.owner, name: this.repo.repo, private: (this.settings.private ? this.settings.private : true), description: this.settings.description ? this.settings.description : '' }
 
               if (this.nop) {
-                this.log.debug(`Creating Repo using template ${JSON.stringify(this.github.rest.repos.createInOrg.endpoint(this.settings))}  `)
+                this.log.debug(`Creating Repo using template ${JSON.stringify(this.github.rest.repos.createUsingTemplate.endpoint(options))}  `)
                 resArray.push(new NopCommand(this.constructor.name, this.repo, this.github.rest.repos.createUsingTemplate.endpoint(options), 'Create Repo Using Template'))
                 return Promise.resolve(resArray)
               }
@@ -264,7 +264,7 @@ module.exports = class Repository extends ErrorStash {
       } else {
         this.log.debug(`Disabling Dependabot alerts for for owner: ${repoData.owner.login} and repo ${repoData.name}`)
         if (this.nop) {
-          resArray.push((new NopCommand(this.constructor.name, this.github.rest.repos.disableVulnerabilityAlerts.endpoint({
+          resArray.push((new NopCommand(this.constructor.name, this.repo, this.github.rest.repos.disableVulnerabilityAlerts.endpoint({
             owner: repoData.owner.login,
             repo: repoData.name
           }), 'Disabling Dependabot alerts')))
@@ -302,7 +302,7 @@ module.exports = class Repository extends ErrorStash {
       } else {
         this.log.debug(`Disabling Dependabot security updates for owner: ${repoData.owner.login} and repo ${repoData.name}`)
         if (this.nop) {
-          resArray.push((new NopCommand(this.constructor.name, this.github.rest.repos.disableAutomatedSecurityFixes.endpoint({
+          resArray.push((new NopCommand(this.constructor.name, this.repo, this.github.rest.repos.disableAutomatedSecurityFixes.endpoint({
             owner: repoData.owner.login,
             repo: repoData.name
           }), 'Disabling Dependabot security updates')))

package.json

@@ -68,6 +68,9 @@
   },
   "jest": {
     "testEnvironment": "node",
+    "setupFilesAfterEnv": [
+      "<rootDir>/test/setup.js"
+    ],
     "reporters": [
       "default",
       "jest-junit"

test/setup.js

@@ -0,0 +1,14 @@
+/* eslint-disable no-undef */
+// Fail tests that produce unexpected console.error output.
+// This ensures that caught-but-logged errors in production code don't
+// silently slip through the test suite (e.g. TypeError inside a catch block
+// that logs via this.log.error = console.error).
+beforeEach(() => {
+  jest.spyOn(console, 'error').mockImplementation((...args) => {
+    throw new Error(`Unexpected console.error call in test: ${args.join(' ')}`)
+  })
+})
+
+afterEach(() => {
+  jest.restoreAllMocks()
+})

test/unit/lib/plugins/milestones.test.js

@@ -12,7 +12,7 @@ describe.skip('Milestones', () => {
       paginate: jest.fn().mockImplementation(() => Promise.resolve()),
       rest: {
         issues: {
-          listMilestonesForRepo: {
+          listMilestones: {
             endpoint: {
               merge: jest.fn().mockImplementation(() => {})
             }

test/unit/lib/plugins/teams.test.js

@@ -23,8 +23,11 @@ describe('Teams', () => {
   beforeEach(() => {
     github = {
       paginate: jest.fn()
-        .mockImplementation(async (fetch) => {
-          const response = await fetch()
+        .mockImplementation(async (fetch, params) => {
+          if (typeof fetch !== 'function') {
+            return []
+          }
+          const response = await fetch(params)
           return response.data
         }),
       rest: {
@@ -43,7 +46,9 @@ describe('Teams', () => {
           })
         }
       },
-      request: jest.fn().mockResolvedValue()
+      request: Object.assign(jest.fn().mockResolvedValue(), {
+        endpoint: jest.fn().mockReturnValue({})
+      })
     }
   })