Skip to content

Commit 4906186

Browse files
committed
Upgrade to node 18
1 parent f724e81 commit 4906186

File tree

7 files changed

+25
-15
lines changed

7 files changed

+25
-15
lines changed

.github/workflows/nightly.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ jobs:
5858
- uses: actions/checkout@v3
5959
- uses: actions/setup-node@v3
6060
with:
61-
node-version: 16
61+
node-version: 18
6262

6363
- name: Install dependencies
6464
run: |

.github/workflows/pr.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
- uses: actions/checkout@v3
1111
- uses: actions/setup-node@v3
1212
with:
13-
node-version: 16
13+
node-version: 18
1414
cache: "yarn"
1515

1616
- name: Install dependencies

.github/workflows/release.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
- uses: actions/checkout@v3
1111
- uses: actions/setup-node@v3
1212
with:
13-
node-version: 16
13+
node-version: 18
1414

1515
- name: Install dependencies
1616
run: |

package.json

+8-5
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"displayName": "Gitpod",
44
"description": "Gitpod Support",
55
"publisher": "gitpod",
6-
"version": "0.0.165",
6+
"version": "0.0.166",
77
"license": "MIT",
88
"icon": "resources/gitpod.png",
99
"repository": {
@@ -14,7 +14,7 @@
1414
"url": "https://github.com/gitpod-io/gitpod/issues"
1515
},
1616
"engines": {
17-
"vscode": "^1.81.0"
17+
"vscode": "^1.82.0"
1818
},
1919
"categories": [
2020
"Other"
@@ -65,7 +65,10 @@
6565
"type": "string",
6666
"description": "The log level for ssh proxy.",
6767
"scope": "application",
68-
"enum": ["none", "debug"],
68+
"enum": [
69+
"none",
70+
"debug"
71+
],
6972
"default": "none"
7073
}
7174
}
@@ -402,7 +405,7 @@
402405
"@types/google-protobuf": "^3.7.4",
403406
"@types/js-yaml": "^4.0.5",
404407
"@types/mocha": "^9.1.1",
405-
"@types/node": "16.x",
408+
"@types/node": "18.x",
406409
"@types/proper-lockfile": "^4.1.2",
407410
"@types/semver": "^7.3.10",
408411
"@types/ssh2": "^0.5.52",
@@ -429,8 +432,8 @@
429432
"webpack-cli": "^4.7.2"
430433
},
431434
"dependencies": {
432-
"@connectrpc/connect-node": "1.1.2",
433435
"@connectrpc/connect": "1.1.2",
436+
"@connectrpc/connect-node": "1.1.2",
434437
"@gitpod/gitpod-protocol": "main-gha",
435438
"@gitpod/local-app-api-grpcweb": "main-gha",
436439
"@gitpod/public-api": "main-gha",

src/heartbeat.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ export class HeartbeatManager extends Disposable {
3333
private lastActivity = new Date().getTime();
3434
private lastActivityEvent: string = 'init';
3535
private isWorkspaceRunning = true;
36-
private heartBeatHandle: NodeJS.Timer | undefined;
36+
private heartBeatHandle: ReturnType<typeof setInterval> | undefined;
3737

3838
private eventCounterMap = new Map<string, number>();
3939

40-
private ideHeartbeatTelemetryHandle: NodeJS.Timer | undefined;
40+
private ideHeartbeatTelemetryHandle: ReturnType<typeof setInterval> | undefined;
4141
private ideHeartbeatData: Pick<IDEHeartbeatTelemetryData, 'successfulCount' | 'totalCount'> = {
4242
successfulCount: 0,
4343
totalCount: 0,

src/metrics.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ export function getConnectMetricsInterceptor(): Interceptor {
194194
export class MetricsReporter {
195195
private static readonly REPORT_INTERVAL = 60000;
196196

197-
private intervalHandler: NodeJS.Timer | undefined;
197+
private intervalHandler: ReturnType<typeof setInterval> | undefined;
198198

199199
constructor(
200200
private readonly gitpodHost: string,

yarn.lock

+11-4
Original file line numberDiff line numberDiff line change
@@ -426,10 +426,12 @@
426426
resolved "https://registry.yarnpkg.com/@types/node/-/node-17.0.35.tgz#635b7586086d51fb40de0a2ec9d1014a5283ba4a"
427427
integrity sha512-vu1SrqBjbbZ3J6vwY17jBs8Sr/BKA+/a/WtjRG+whKg1iuLFOosq872EXS0eXWILdO36DHQQeku/ZcL6hz2fpg==
428428

429-
430-
version "16.11.36"
431-
resolved "https://registry.yarnpkg.com/@types/node/-/node-16.11.36.tgz#9ab9f8276987132ed2b225cace2218ba794fc751"
432-
integrity sha512-FR5QJe+TaoZ2GsMHkjuwoNabr+UrJNRr2HNOo+r/7vhcuntM6Ee/pRPOnRhhL2XE9OOvX9VLEq+BcXl3VjNoWA==
429+
430+
version "18.19.34"
431+
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.19.34.tgz#c3fae2bbbdb94b4a52fe2d229d0dccce02ef3d27"
432+
integrity sha512-eXF4pfBNV5DAMKGbI02NnDtWrQ40hAN558/2vvS4gMpMIxaf6JmD7YjnZbq0Q9TDSSkKBamime8ewRoomHdt4g==
433+
dependencies:
434+
undici-types "~5.26.4"
433435

434436
"@types/node@>=12.12.47", "@types/node@>=13.7.0":
435437
version "18.14.2"
@@ -3993,6 +3995,11 @@ underscore@^1.12.1:
39933995
resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.13.6.tgz#04786a1f589dc6c09f761fc5f45b89e935136441"
39943996
integrity sha512-+A5Sja4HP1M08MaXya7p5LvjuM7K6q/2EaC0+iovj/wOcMsTzMvDFbasi/oSapiwOlt252IqsKqPjCl7huKS0A==
39953997

3998+
undici-types@~5.26.4:
3999+
version "5.26.5"
4000+
resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-5.26.5.tgz#bcd539893d00b56e964fd2657a4866b221a65617"
4001+
integrity sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==
4002+
39964003
undici@^5.25.4:
39974004
version "5.25.4"
39984005
resolved "https://registry.yarnpkg.com/undici/-/undici-5.25.4.tgz#7d8ef81d94f84cd384986271e5e5599b6dff4296"

0 commit comments

Comments
 (0)