Keybindings should map via keycodes instead of text

[nik-rev]

When creating a mapping like <C-t>, switching to another language and pressing the same physical keys won't trigger the keybind

Example

I am using Russian and English keyboard layouts, and I have the following in my config:

glide.keymaps.set("normal", "<C-t>", "tab_prev")
glide.keymaps.set("normal", "<C-n>", "tab_next")

On English layout - this works fine. But if I switch to Russian layout, it won't work because pressing the same physical keys will send the text <C-е> and <C-т>

In order to allow the same physical key combination to trigger the same action regardless of which layout is used, I need to duplicate every keybind for every additional language that I use:

// english
glide.keymaps.set("normal", "<C-t>", "tab_prev")
// russian
glide.keymaps.set("normal", "<C-т>", "tab_prev")
// english
glide.keymaps.set("normal", "<C-n>", "tab_next")
// russian
glide.keymaps.set("normal", "<C-е>", "tab_next")

Could keybindings map via keycodes instead of the text that browser receives when a certain key is pressed (which will differ depending on layout)

[RobertCraigie]

👍 we have a similar issue in general on macOS right now as option is used for diacritics, e.g. <A-p> actually gets sent as <A-π>.

Would you expect the keymaps to resolve based on the physical key by default? As I only use one layout it's not immediately clear to me which behaviour most users would expect.

[nik-rev]

Would you expect the keymaps to resolve based on the physical key by default? As I only use one layout it's not immediately clear to me which behaviour most users would expect.

Yes, by default is the behavior I've observed in all software that support this. e.g. Zed editor

[RobertCraigie]

@nik-rev please try out the latest version, 0.1.59a, it adds support for matching keymaps based on the key code instead of the key!

See these docs for more information.

I didn't make it the default as there are some UX improvements I'd like to make before considering doing so. Like helping the user make sure the right keyboard layout is configured.