Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: const validation overflow #3749

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: const validation overflow #3749

wants to merge 5 commits into from

Conversation

petar-dambovaliev
Copy link
Contributor

@petar-dambovaliev petar-dambovaliev commented Feb 13, 2025

Closes 3496

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Feb 13, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 13, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 23.14815% with 83 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/values_conversions.go 20.19% 55 Missing and 28 partials ⚠️

📢 Thoughts on this report? Let us know!

@Kouteki Kouteki added this to the 🚀 Mainnet beta launch milestone Feb 14, 2025
Comment on lines +172 to +178
func main() {
const f = 0x1p1023 * (1 + (1 - 0x1p-52))
println(float32(f))
}

`,
`test/main.go:5:13: cannot convert constant of type Float64Kind to Float32Kind`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just filetests and I don't get why we should put them here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if instead, when we call ConvertTo we set isConst to true when m.PreprocessorMode is true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Incorrect Handling of Constant Conversion (math.MaxFloat64 to float32 )
4 participants