-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): add Dragan's home realm to examples #3780
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Pending initial approval by a review team member, or review from tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes, see comments.
Also, think about how you can make your home realm more unique; currently we're getting more and more similar home realms, losing the reasoning for adding them to the examples folder, since they can just be permissionlessly deployed.
Please, either try to change up your home realm a bit to have good demonstrational value, or simply deploy it via gnokey
:)
@@ -0,0 +1,63 @@ | |||
package config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should remove this package (the approach is outdated and its been reused too much for the examples folder). Just add ownable
functionality to your home realm and export the object.
sb.WriteString("# Hi, I'm Dragan \n\n") | ||
sb.WriteString("---\n") | ||
sb.WriteString("## 👋 About me\n") | ||
sb.WriteString(aboutMe) | ||
sb.WriteString("---\n") | ||
sb.WriteString(renderProjects(gnoProjects, "⚙️ Gno Projects")) | ||
sb.WriteString("---\n") | ||
sb.WriteString(renderProjects(web3Projects, "🌐 Web3 Projects")) | ||
sb.WriteString("---\n") | ||
sb.WriteString(renderProjects(otherProjects, "📂 Other Projects")) | ||
sb.WriteString("---\n") | ||
sb.WriteString("## 🎮 Games\n") | ||
sb.WriteString("### " + "⏳" + comingSoon + "\n") | ||
sb.WriteString("---\n") | ||
sb.WriteString(renderRewardsAndAchievements()) | ||
sb.WriteString(renderSocialLinks()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the string builder and just append to a single string, it's more readable
} | ||
|
||
func isAuthorized(addr std.Address) bool { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
random newline, run make fmt
in the examples folder
This PR contains my home realm where I introduce myself and share more details about me. I have also implemented basic functions, including adding, updating, and deleting projects and links.