feat(commondao): Add Common DAO realm #3791
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently anyone can invite. We have to add an admin or use a package like `p/moul/authz` once available to make it permissioned.
jeronimoalbi
requested review from
wyhaines,
ajnavarro,
ilgooz,
salmad3 and
leohhhn
github-actions
bot
added
the
🧾 package/realm
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
|
Related to #3605 |
Done to simplify iteration and pagination.
Iterator can be cerated by callers so the `Iterate` public function was removed as it's redundanto now.
jeronimoalbi
commented
Feb 26, 2025
Comment on lines
+3
to
+6
| func Render(string) string { | ||
| // TODO: Implement Render support | ||
| return "" | ||
| } |
There was a problem hiding this comment.
Render will be implemented in a following PR focused on implementing it
jeronimoalbi
commented
Feb 26, 2025
| // Invite invites a user to the realm. | ||
| // A user invitation is required to start creating new DAOs. | ||
| func Invite(invitee std.Address) { | ||
| // TODO: Use an authority to restrict inviters when `p/moul/authz` is available |
There was a problem hiding this comment.
Authority support will be added in a following PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one approach for a Common DAO realm that aims to create a new realm to allow dApps to create DAOs on demand.
Realm should allow creating standalone DAOs and tree based DAOs making it possible for dApps to choose the DAO mechanics that they want the Common DAO realm to provide.
Many of these mechanics will be based on AtomOne's Common DAO Spec.