fix(gnoweb): breadcrumb generation for consistent argument and query handling #3835
+44
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
generateBreadcrumbPaths
function to provide a consistent model for handling breadcrumb parts extracted from the URL path, arguments, and query parameters. The changes include:Consistent Extraction of Parts:
The existing logic that splits the URL path into parts remains unchanged.
New Argument Parts (ArgParts):
Instead of storing all arguments as a single string, we now split the url.Args value (i.e., the part after the
:
) into individual segments. These segments are processed similarly to the path parts, with cumulative URLs generated for each segment. This provides a more granular and consistent breadcrumb structure.Query Parameters Handling:
Query parameters (after the
?
) are iterated over and added to a new Queries slice. Since iterating over an empty map is safe, no additional condition is required here.TODO: update query value on click from input
Captures
Before
After