Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i386 to CI #717

Open
argilo opened this issue Dec 9, 2023 · 4 comments
Open

Add i386 to CI #717

argilo opened this issue Dec 9, 2023 · 4 comments
Labels
Enhancement new kernel entirely or for some specific ARCH

Comments

@argilo
Copy link
Member

argilo commented Dec 9, 2023

Running VOLK's test suite on i386 revealed a broken protokernel and many broken tests:

Given this success, it would seem useful to add i386 to CI to catch more future bugs.

@argilo argilo added the Enhancement new kernel entirely or for some specific ARCH label Dec 9, 2023
@jdemel
Copy link
Contributor

jdemel commented Dec 10, 2023

Looking at the fixes, I agree.

@jdemel
Copy link
Contributor

jdemel commented Dec 10, 2023

I'm looking for a way to run i386. A native GH Action would be preferable because they are much faster. I do have some hope that MacOS13 arm64 images do that for us on MacOS.

For non-x86, we use run-on-arch. This action doesn't provide an i386 image.

@argilo
Copy link
Member Author

argilo commented Dec 10, 2023

@argilo
Copy link
Member Author

argilo commented Dec 10, 2023

Another way of catching floating-point bugs might be to use a tool like https://github.com/verificarlo/verificarlo.

But an i386 build still would have been needed to catch #714.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement new kernel entirely or for some specific ARCH
Projects
None yet
Development

No branches or pull requests

2 participants