cleanup changes

Author: dawidgora

models/repo/release.go

@@ -6,7 +6,6 @@ package repo
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"html/template"
 	"net/url"
@@ -325,10 +324,6 @@ func GetLatestReleaseByRepoID(ctx context.Context, repoID int64) (*Release, erro
 
 // GetPreviousPublishedRelease returns the most recent published release created before the provided release.
 func GetPreviousPublishedRelease(ctx context.Context, repoID int64, current *Release) (*Release, error) {
-	if current == nil {
-		return nil, errors.New("current release must not be nil")
-	}
-
 	cond := builder.NewCond().
 		And(builder.Eq{"repo_id": repoID}).
 		And(builder.Eq{"is_draft": false}).

services/release/notes_test.go

@@ -29,7 +29,6 @@ func TestGenerateReleaseNotes(t *testing.T) {
 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
 	gitRepo, err := gitrepo.OpenRepository(t.Context(), repo)
 	require.NoError(t, err)
-	t.Cleanup(func() { gitRepo.Close() })
 
 	mergedCommit := "90c1019714259b24fb81711d4416ac0f18667dfa"
 	pr := createMergedPullRequest(t, repo, mergedCommit, 5)
@@ -57,30 +56,14 @@ func TestGenerateReleaseNotes_NoReleaseFallsBackToTags(t *testing.T) {
 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
 	gitRepo, err := gitrepo.OpenRepository(t.Context(), repo)
 	require.NoError(t, err)
-	t.Cleanup(func() { gitRepo.Close() })
 
 	mergedCommit := "90c1019714259b24fb81711d4416ac0f18667dfa"
 	createMergedPullRequest(t, repo, mergedCommit, 5)
 
-	var releases []repo_model.Release
-	err = db.GetEngine(t.Context()).
-		Where("repo_id=?", repo.ID).
-		Asc("id").
-		Find(&releases)
-	require.NoError(t, err)
-
 	_, err = db.GetEngine(t.Context()).
 		Where("repo_id=?", repo.ID).
 		Delete(new(repo_model.Release))
 	require.NoError(t, err)
-	t.Cleanup(func() {
-		if len(releases) == 0 {
-			return
-		}
-		ctx := context.Background()
-		_, err := db.GetEngine(ctx).Insert(&releases)
-		require.NoError(t, err)
-	})
 
 	result, err := GenerateReleaseNotes(t.Context(), repo, gitRepo, GenerateReleaseNotesOptions{
 		TagName: "v1.2.0",
@@ -200,10 +183,6 @@ func insertTestRelease(ctx context.Context, t *testing.T, repo *repo_model.Repos
 
 	_, err := db.GetEngine(ctx).Insert(release)
 	require.NoError(t, err)
-	t.Cleanup(func() {
-		_, err := db.GetEngine(context.Background()).ID(release.ID).Delete(new(repo_model.Release))
-		require.NoError(t, err)
-	})
 
 	return release
 }

web_src/js/features/repo-release.ts

@@ -62,21 +62,18 @@ function initGenerateReleaseNotes() {
   const generateUrl = button.getAttribute('data-generate-url');
 
   button.addEventListener('click', async () => {
-    const tagName = tagNameInput?.value.trim();
+    const tagName = tagNameInput.value.trim();
+
     if (!tagName) {
       showErrorToast(missingTagMessage);
       tagNameInput?.focus();
       return;
     }
-    if (!generateUrl) {
-      showErrorToast('Missing release notes endpoint');
-      return;
-    }
 
     const form = new URLSearchParams();
     form.set('tag_name', tagName);
-    form.set('tag_target', targetInput?.value || '');
-    form.set('previous_tag', previousTagSelect?.value || '');
+    form.set('tag_target', targetInput.value || '');
+    form.set('previous_tag', previousTagSelect.value || '');
 
     button.classList.add('loading', 'disabled');
     try {
@@ -85,16 +82,13 @@ function initGenerateReleaseNotes() {
       });
       const data = await resp.json();
       if (!resp.ok) {
-        throw new Error(data.errorMessage || data.error || resp.statusText);
+        throw new Error(data.errorMessage || resp.statusText);
       }
 
-      if (previousTagSelect && 'previous_tag' in data) {
-        previousTagSelect.value = data.previous_tag || '';
-        previousTagSelect.dispatchEvent(new Event('change', {bubbles: true}));
-      }
-      if (data && 'content' in data) {
-        applyGeneratedReleaseNotes(data.content || '');
-      }
+      previousTagSelect.value = data.previous_tag;
+      previousTagSelect.dispatchEvent(new Event('change', {bubbles: true}));
+
+      applyGeneratedReleaseNotes(data.content);
     } catch (error) {
       const message = error instanceof Error ? error.message : String(error);
       showErrorToast(message);