Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join clause does not implement the clause interface #7188

Closed
gregorgebhardt opened this issue Sep 5, 2024 · 1 comment
Closed

Join clause does not implement the clause interface #7188

gregorgebhardt opened this issue Sep 5, 2024 · 1 comment
Assignees
Labels

Comments

@gregorgebhardt
Copy link

GORM Playground Link

I tried to but running the test.sh in the playground repo returns the error:

go: gorm.io/playground imports
        gorm.io/gen/examples: cannot find module providing package gorm.io/gen/examples

Description

When trying to add a join clause to my query via clause.Join{...} and later

sqlQuery := db.WithContext(ctx).Model(...)
sqlQuery.Clauses(joinClause)

The join ends up in a WHERE condition. The problem is that within the function func (db *DB) Clauses(conds ...clause.Expression) (tx *DB), there is a type switch on the elements in conds. But since clause.Join neither implements the clause.Interface nor the StatementModifier, it will be put into the whereConds slice and ends up in the WHERE conditions...

@github-actions github-actions bot added the type:missing reproduction steps missing reproduction steps label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants