Merge pull request #39 from siddontang/fix-row-decode-panic

fix row decode panic

Author: siddontang

Makefile

@@ -1,11 +1,13 @@
+ROOT_PATH=$(shell pwd)
+
 all: build
 
 build:
-	export GOBIN=./bin && \
+	export GOBIN=${ROOT_PATH}/bin && \
 	godep go install ./...
 
 test: build
-	export GOBIN=./bin && \
+	export GOBIN=${ROOT_PATH}/bin && \
 	godep go test ./...
 
 clean:

replication/replication_test.go

@@ -260,6 +260,8 @@ func (t *testSyncerSuite) TestMysqlBinlogCodec(c *C) {
 		t.testSync(c, nil)
 	}()
 
+	os.RemoveAll("./var")
+
 	err := t.b.StartBackup("./var", mysql.Position{"", uint32(0)}, 2*time.Second)
 	c.Check(err, Equals, ErrGetEventTimeout)
 

replication/row_event.go

@@ -257,7 +257,13 @@ func (e *RowsEvent) Decode(data []byte) error {
 	var err error
 
 	// ... repeat rows until event-end
-	for pos < len(data) {
+	// Why using pos < len(data) - 1 instead of origin pos < len(data) to check?
+	// See mysql
+	//  https://github.com/mysql/mysql-server/blob/5.7/sql/log_event.cc#L9006
+	//	https://github.com/mysql/mysql-server/blob/5.7/sql/log_event.cc#L2492
+	// A user panics here but he can't give me more information, and using len(data) - 1
+	// fixes this panic, so I will try to construct a test case for this later.
+	for pos < len(data)-1 {
 		if n, err = e.decodeRows(data[pos:], e.Table, e.ColumnBitmap1); err != nil {
 			return errors.Trace(err)
 		}