Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile time regression(?) #1610

Open
IvanInventor opened this issue Sep 26, 2024 · 1 comment · May be fixed by #1628
Open

Compile time regression(?) #1610

IvanInventor opened this issue Sep 26, 2024 · 1 comment · May be fixed by #1628
Labels
bug This has been identified as a bug topic:buildsystem Related to the buildsystem or CI setup
Milestone
4.x

Comments

@IvanInventor
Copy link

Godot version

godot-cpp version

2ffff66

System information

Arch Linux

Issue description

Commit introduces ~X3 compilation time.

Steps to reproduce

Bisected from master, benchmarked with

time scons

command

Approximate compile time of good commit

real	5m4.576s
user	44m50.995s
sys	1m48.742s

bad commit

real	15m37.927s
user	145m58.519s
sys	3m25.119s

Minimal reproduction project

godot-cpp repo
@dsnopek dsnopek added the topic:buildsystem Related to the buildsystem or CI setup label Sep 27, 2024
@dsnopek dsnopek added this to the 4.x milestone Sep 27, 2024
@dsnopek
Copy link
Collaborator

dsnopek commented Sep 27, 2024

My machine appears to be much faster than yours, however, I am still able to reproduce this in my testing.

I tried with these commands:

scons -c
time scons

On 730ccaa (the commit before PR #1162):

real    0m35.237s
user    13m15.284s
sys     2m19.489s

On 96565e1 (current master):

real    1m55.579s
user    51m56.977s
sys     3m50.841s

My guess is that this is from the changes to type_info.hpp which ends up getting included everywhere. I'm not sure how to improve this...

cc @Repiteo

@dsnopek dsnopek added the bug This has been identified as a bug label Sep 27, 2024
@dsnopek dsnopek mentioned this issue Oct 17, 2024
Open
@IvanInventor IvanInventor linked a pull request Oct 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This has been identified as a bug topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
4.x
Development

Successfully merging a pull request may close this issue.

fix typed_dictionary compile-time regression IvanInventor/godot-cpp
2 participants
@dsnopek @IvanInventor