Implemented a very simple SSAO in GLES3.

Author: jon1solution

drivers/gles3/effects/post_effects.cpp

@@ -124,7 +124,6 @@ void PostEffects::post_copy(
 	if (p_luminance_multiplier != 1.0) {
 		flags |= PostShaderGLES3::USE_LUMINANCE_MULTIPLIER;
 	}
-	flags |= PostShaderGLES3::USE_LUMINANCE_MULTIPLIER;
 
 	bool success = post.shader.version_bind_shader(post.shader_version, mode, flags);
 	if (!success) {

drivers/gles3/effects/post_effects.h

@@ -59,10 +59,9 @@ class PostEffects {
 	~PostEffects();
 
 	void post_copy(GLuint p_dest_framebuffer, Size2i p_dest_size, GLuint p_source_color,
-			GLuint p_source_depth, bool p_ssao_enabled, int p_ssao_quality_level, float p_ssao_strength, float p_ssao_radius, // These are for SSAO.
-			Size2i p_source_size, float p_luminance_multiplier, const Glow::GLOWLEVEL *p_glow_buffers, float p_glow_intensity, 
-			float p_srgb_white, 
-			uint32_t p_view = 0, bool p_use_multiview = false, uint64_t p_spec_constants = 0);
+			GLuint p_source_depth, bool p_ssao_enabled, int p_ssao_quality_level, float p_ssao_strength, float p_ssao_radius,
+			Size2i p_source_size, float p_luminance_multiplier, const Glow::GLOWLEVEL *p_glow_buffers, float p_glow_intensity,
+			float p_srgb_white, uint32_t p_view = 0, bool p_use_multiview = false, uint64_t p_spec_constants = 0);
 };
 
 } //namespace GLES3

drivers/gles3/rasterizer_scene_gles3.cpp

@@ -2562,13 +2562,9 @@ void RasterizerSceneGLES3::render_scene(const Ref<RenderSceneBuffers> &p_render_
 	glBindFramebuffer(GL_FRAMEBUFFER, fbo);
 	glViewport(0, 0, rb->internal_size.x, rb->internal_size.y);
 
-	scene_state.reset_gl_state();
-
 	// If SSAO is enabled, we definitely need the depth buffer.
-	if (render_data.environment.is_valid()) {
-		if (environment_get_ssao_enabled(render_data.environment)) {
-			scene_state.used_depth_texture = true;
-		}
+	if (ssao_enabled) {
+		scene_state.used_depth_texture = true;
 	}
 
 	// Do depth prepass if it's explicitly enabled
@@ -2861,17 +2857,11 @@ void RasterizerSceneGLES3::_render_post_processing(const RenderDataGLES3 *p_rend
 	if (p_render_data->environment.is_valid()) {
 		ssao_enabled = environment_get_ssao_enabled(p_render_data->environment);
 		// This SSAO is not implemented the same way, but uses the intensity and radius
-		// in a similar way.  The 'detail' value is used as the distance falloff control.
-		// The parameters are scaled so the SSAO defaults look good (though different).
+		// in a similar way.  The parameters are scaled so the SSAO defaults look ok.
 		ssao_strength = environment_get_ssao_intensity(p_render_data->environment) * 2.0;
 		ssao_radius = environment_get_ssao_radius(p_render_data->environment) * 0.5;
 	}
 
-	if (ssao_enabled) {
-		// I think this already happened?
-		//rb->check_backbuffer(scene_state.used_screen_texture, scene_state.used_depth_texture);
-	}
-
 	uint64_t bcs_spec_constants = 0;
 	if (p_render_data->environment.is_valid()) {
 		bool use_bcs = environment_get_adjustments_enabled(p_render_data->environment);
@@ -2940,10 +2930,9 @@ void RasterizerSceneGLES3::_render_post_processing(const RenderDataGLES3 *p_rend
 
 			// Copy color buffer
 			post_effects->post_copy(fbo_rt, target_size, color,
-					depth_buffer, ssao_enabled, ssao_quality, ssao_strength, ssao_radius, // These are new for SSAO.
-					internal_size, p_render_data->luminance_multiplier, glow_buffers, glow_intensity, 
-					srgb_white,
-					0, false, bcs_spec_constants);
+					depth_buffer, ssao_enabled, ssao_quality, ssao_strength, ssao_radius,
+					internal_size, p_render_data->luminance_multiplier, glow_buffers, glow_intensity,
+					srgb_white, 0, false, bcs_spec_constants);
 
 			// Copy depth buffer
 			glBindFramebuffer(GL_READ_FRAMEBUFFER, fbo_int);
@@ -3015,14 +3004,12 @@ void RasterizerSceneGLES3::_render_post_processing(const RenderDataGLES3 *p_rend
 				glBindFramebuffer(GL_FRAMEBUFFER, fbos[2]);
 				glFramebufferTextureLayer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, write_color, 0, v);
 				post_effects->post_copy(fbos[2], target_size, source_color,
-						read_depth, ssao_enabled, ssao_quality, ssao_strength, ssao_radius, // These are new for SSAO.
-						internal_size, p_render_data->luminance_multiplier, glow_buffers, glow_intensity, 
-						srgb_white,
-						v, true, bcs_spec_constants);
+						read_depth, ssao_enabled, ssao_quality, ssao_strength, ssao_radius,
+						internal_size, p_render_data->luminance_multiplier, glow_buffers, glow_intensity,
+						srgb_white, v, true, bcs_spec_constants);
 			}
 
 			// Copy depth
-			//GLuint read_depth = rb->get_internal_depth();
 			GLuint write_depth = texture_storage->render_target_get_depth(render_target);
 
 			glBindFramebuffer(GL_READ_FRAMEBUFFER, fbos[0]);