Skip to content

Commit 5ab9d96

Browse files
eaygopherbot
authored andcommitted
crypto/tls: fix a testing deadlock that occurs on a TLS protocol error
A Go routine was, on an error, returning without sending a message on its signaling channel, so the main program was blocking forever waiting for a message that was never sent. Found while breaking crypto/tls. Change-Id: Id0b3c070a27cabd852f74e86bb9eff5c66b86d28 GitHub-Last-Rev: 4d84fb8 GitHub-Pull-Request: #53216 Reviewed-on: https://go-review.googlesource.com/c/go/+/410274 Auto-Submit: Sean Liao <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Sean Liao <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 5715d73 commit 5ab9d96

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/crypto/tls/handshake_server_test.go

-1
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,6 @@ func TestRenegotiationExtension(t *testing.T) {
236236
n, err := c.Read(buf)
237237
if err != nil {
238238
t.Errorf("Server read returned error: %s", err)
239-
return
240239
}
241240
c.Close()
242241
bufChan <- buf[:n]

0 commit comments

Comments
 (0)